Skip to content

Allow ClipRRect.borderRadius to support BorderRadiusDirectional#101200

Merged
fluttergithubbot merged 5 commits intoflutter:masterfrom
thecalamiity:master
Apr 9, 2022
Merged

Allow ClipRRect.borderRadius to support BorderRadiusDirectional#101200
fluttergithubbot merged 5 commits intoflutter:masterfrom
thecalamiity:master

Conversation

@thecalamiity
Copy link
Contributor

@thecalamiity thecalamiity commented Apr 1, 2022

Fixes #91997

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 1, 2022
Copy link
Member

@nt4f04uNd nt4f04uNd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with those two spaces
This will need a secondary review

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

I restarted the failed check. If it doesn't pass, you may have to rebase this PR to the latest master.

@thecalamiity thecalamiity requested a review from goderbauer April 6, 2022 22:44
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux fuchsia_precache has failed. Please fix the issues identified (or deflake) before re-applying this label.

@thecalamiity thecalamiity requested a review from goderbauer April 9, 2022 03:42
@thecalamiity
Copy link
Contributor Author

I pushed an empty commit. Hopefully all tests will pass now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal] Allow ClipRRect.borderRadius to support BorderRadiusDirectional

4 participants