ignore prefer_final_parameters in generated_plugin_registrant template#101253
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Apr 14, 2022
Merged
ignore prefer_final_parameters in generated_plugin_registrant template#101253fluttergithubbot merged 1 commit intoflutter:masterfrom
prefer_final_parameters in generated_plugin_registrant template#101253fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
Contributor
Author
Contributor
|
@DetachHead looks like you have a legitimate test failure: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20framework_tests_misc/17701/overview |
goderbauer
reviewed
Apr 7, 2022
Contributor
Author
|
@christopherfujino no idea what couldve caused that but it looks like all the tests are passing now after i applied @goderbauer's suggestion |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fixes #101252
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.