It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Builds are currently failing because maven-publish creates different Android variants as classifiers (io.flutter.devicelab.hello:flutter:1.0:debug) while the old publish plugin created them as different artefacts with the variant appended to the artifactId (io.flutter.devicelab.hello:flutter_debug:1.0).

In this case, the new behaviour would be considered more "correct" from a grade perspective, but it might cause other issues in the ecosystem.

It looks like it's possible to adapt project.components.all to mimic the old behaviour - I'll see what I can do.

you may also need to change:

Maybe, remove templateAndroidGradlePluginVersionForModule and replace with templateDefaultGradleVersion.

Based on gradle/gradle#12324 (comment), I think the issue appears to be that we can't configure multiple publications at once. I wonder if it could just configure the task that was currently requested from Dart, and this way, just configure a single publication.

Based on gradle/gradle#12324 (comment), I think the issue appears to be that we can't configure multiple publications at once. I wonder if it could just configure the task that was currently requested from Dart, and this way, just configure a single publication.

So that is kind of what I'm trying to do with project.components.forEach { component ->, which does the trick - it produces _debug, _profile and _release artifactId's. The next step is to convince gradle to resolve those correctly where Flutter plugins are direct dependencies of each other:

> Publishing is not able to resolve a dependency on a project with multiple publications that have different coordinates.
Found the following publications in project ':plugin_with_android':
- Maven publication 'debug' with coordinates io.flutter.devicelab.plugin_with_android:plugin_with_android_debug:1.0
- Maven publication 'profile' with coordinates io.flutter.devicelab.plugin_with_android:plugin_with_android_profile:1.0
- Maven publication 'release' with coordinates io.flutter.devicelab.plugin_with_android:plugin_with_android_release:1.0

Ok, I'm not finding a way to get the maven-publish plugin to resolve these dependencies correctly. What I would like to propose is to put a relocation pom at the old coordinates and then publish the actual artefacts as per the new gradle way (one artefact with classifiers). This way, we keep backward compatibility, but still publish in the "default" way.

For reference, this is what the repo structure would then look like:

repo/
  com/
     example/
        plugin1/                                         <-- new way with classifiers
             1.0/
                 plugin1-1.0.pom
                 plugin1-1.0-debug.aar
                 plugin1-1.0-profile.aar
                 plugin1-1.0-release.aar
        plugin1_debug/                            <-- Maintain backward compatibility             
             1.0/
                 plugin1_debug-1.0.pom
                 plugin1_debug-1.0.aar
        plugin1_profile/
             1.0/
                 plugin1_profile-1.0.pom
                 plugin1_profile-1.0.aar
        plugin1_release/
             1.0/
                 plugin1_release-1.0.pom
                 plugin1_release-1.0.aar

The _{variant} POM files would then look the same as they do now, with the addition of a <relocation> section

  <distributionManagement>
    <relocation>
      <groupId>com.example</groupId>
      <artifactId>plugin1<artifactId>
      <version>1.0</version>
      <message>Use classifiers rather than _variant for new publish plugin</message>
    </relocation>
  </distributionManagement>

For now, we can also publish the AARs in the old location, but change the documentation to point to the new location.

Thoughts?

@AesSedai101 makes sense :) Thank you for doing all the research!

@AesSedai101 makes sense :) Thank you for doing all the research!

perfect! I'll make the changes and update the tests sometime today 🙂

btw, we are hiring https://docs.flutter.dev/jobs :)

#111643

@AesSedai101