Don't build surface until the platform view has been created#101399
Merged
fluttergithubbot merged 14 commits intoflutter:masterfrom Apr 7, 2022
Merged
Don't build surface until the platform view has been created#101399fluttergithubbot merged 14 commits intoflutter:masterfrom
fluttergithubbot merged 14 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
framework
cyanglaz
reviewed
Apr 6, 2022
| height: double.infinity, | ||
| )); | ||
|
|
||
| _OnLayoutCallback? onLayout; |
added 2 commits
April 6, 2022 15:34
added 2 commits
April 6, 2022 18:22
cyanglaz
reviewed
Apr 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 7, 2022
stuartmorgan-g
added a commit
to stuartmorgan-g/flutter
that referenced
this pull request
Aug 9, 2022
Fixes regressions from flutter#101399: - For Hybrid Composition, there is a common race where `create` will be called by the `PlatformViewLink` even though it has already been successfully called by the plugin itself. This causes exceptions on use of many Hybrid Composition plugins, and blocks adopting the new forced-HC mode in the google_maps_flutter plugin, for instance. - The documented behavior of `AndroidViewController`, which is that `setSize` would create it on demand, was removed. That logic had been moved to an internal call site, but there may have been public callers expecting that behavior as well so it's better to keep the logic in the code documented to have that behavior. Part of flutter#107297
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds a placeholder that is used to capture the size of the render object after layout, then
it communicates the size to the controller, so the platform view can be created on platforms
that need to wait for the creation to happen prior to building the surface.
Fixes a crash issue in Fuchsia:
https://logs.chromium.org/logs/turquoise/buildbucket/cr-buildbucket/8817759165575272161/+/u/failures/AEMU-_1_/attempt_0__fail_/failed:_fuchsia-pkg:__fuchsia.com_touch-input-test-ip_meta_touch-input-test-ip-component.cm/infra_and_test_std_and_klog.txt