Merged
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
Author
|
@dnfield Can you run these benchmarks on the target devices? |
Contributor
Author
|
Hmm, shouldn't benchmarks be exempt from the test check robots? |
Contributor
|
I'll run these on the low end device next time I'm in the office |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
flar
added
waiting for tree to go green
and removed
c: contributor-productivity
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Member
|
Related: #101518 |
Contributor
Author
|
Here are the results of doing an A/B run on these benchmarks against a pre-DlColorSource engine. For each of these results, the default, or A engine is using the DlColorSource and the local, or B engine is using SkGradient. The "Speed-up" column is how much faster Sk is against Dl (or slower if the factor is less than 1.0). Results for the "static" version of the benchmark: And the results for the "consistent" version of the benchmark: And results for the "dynamic" version of the benchmark: |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are seeing a slight performance regression on some downstream projects on an engine commit that changed the way we store paint shaders (image, gradient, etc.) and it looks like we don't have any benchmarks to track the performance of our gradient shaders. This PR adds 3 gradient benchmarks: