Create when offline style #101589
Merged
fluttergithubbot merged 17 commits intoflutter:masterfrom Apr 11, 2022
Merged
Conversation
…flutter into create_when_offline # Conflicts: # packages/flutter_tools/test/commands.shard/hermetic/create_usage_test.dart
flutter-dashboard
bot
added
the
tool
# Conflicts: # packages/flutter_tools/lib/src/runner/flutter_command.dart # packages/flutter_tools/test/commands.shard/hermetic/create_usage_test.dart
| // First always update universal artifacts, as some of these (e.g. | ||
| // ios-deploy on macOS) are required to determine `requiredArtifacts`. | ||
| bool offline; | ||
| final bool offline; |
Contributor
There was a problem hiding this comment.
I think this can be a one-liner:
final bool offline = boolArg('offline') ?? false;
Contributor
There was a problem hiding this comment.
nvm, discussed offline
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing style nits from previous PR #100941
Pre-launch Checklist
///).