Added missing device requirement for "Mac entrypoint_dart_registrant"#101599
Merged
gaaclarke merged 3 commits intoflutter:masterfrom Apr 11, 2022
Merged
Added missing device requirement for "Mac entrypoint_dart_registrant"#101599gaaclarke merged 3 commits intoflutter:masterfrom
gaaclarke merged 3 commits intoflutter:masterfrom
Conversation
keyonghan
reviewed
Apr 8, 2022
.ci.yaml
Outdated
Contributor
There was a problem hiding this comment.
We also need to update the builder name: Mac entrypoint_dart_registrant -> Mac_android entrypoint_dart_registrant to enforce an android device.
Member
Author
There was a problem hiding this comment.
Done, I also moved it to be next to the other Mac_android tasks.
gaaclarke
force-pushed
the
entrypoint-needs-android
branch
from
235ee4b to
62a7f8f
Compare
keyonghan
reviewed
Apr 8, 2022
.ci.yaml
Outdated
Comment on lines
+3071
to
+3076
| caches: >- | ||
| [ | ||
| {"name":"gradle","path":"gradle"} | ||
| ] | ||
| dependencies: >- | ||
| [] |
Contributor
There was a problem hiding this comment.
Nit: these are not necessary as the platform level includes them: https://github.com/flutter/flutter/blob/master/.ci.yaml#L90
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Member
Author
|
Landing without googletesting passing, there is no way this could affect google testing since it only edits ci.yaml. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds requirement for Android device.
link to failure:
https://ci.chromium.org/ui/p/flutter/builders/staging/Mac%20entrypoint_dart_registrant/781/overview
test-exempt: is a test
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.