Unpause and remove breakpoints when detaching from Flutter process with DAP#101695
Merged
DanTup merged 1 commit intoflutter:masterfrom Apr 11, 2022
Merged
Unpause and remove breakpoints when detaching from Flutter process with DAP#101695DanTup merged 1 commit intoflutter:masterfrom
DanTup merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up by removing breakpoints, disabling pause-on-exceptions and resuming threads when detaching from a Flutter process you attached to to debug (this matches the Dart DAP behaviour).
This prevents a user attaching, setting a bunch of breakpoints to debug, then detaching and finding the app is still unresponsive because it's hitting breakpoints without a debugger attached.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.