Update module_test_ios google_sign_in version#101729
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Apr 12, 2022
Merged
Update module_test_ios google_sign_in version#101729fluttergithubbot merged 1 commit intoflutter:masterfrom
fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
jmagman
added
a: tests
flutter-dashboard
bot
added
the
c: contributor-productivity
jmagman
force-pushed
the
module-gsi-version
branch
from
a08d301 to
4c60c50
Compare
jmagman
force-pushed
the
module-gsi-version
branch
from
4c60c50 to
b3f2571
Compare
christopherfujino
approved these changes
Apr 12, 2022
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
RSLGTM. Would be nice to make this a little easier to update the next time, but I don't have any good ideas off the top of my head.
hellohuanlin
approved these changes
Apr 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
google_sign_inwas hardcoded to 4.5.1, which did not contain the fix in 5.0.7 to mark arm simulators as unsupported. flutter/plugins#4208Also remove deprecated
device_infoin favor ofurl_launcher.Fixes #101722
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.