Skip to content

[WIP]Make RepaintBoundaries raster-cachable#101754

Closed
ColdPaleLight wants to merge 1 commit intoflutter:masterfrom
ColdPaleLight:repaint_boundary_opt
Closed

[WIP]Make RepaintBoundaries raster-cachable#101754
ColdPaleLight wants to merge 1 commit intoflutter:masterfrom
ColdPaleLight:repaint_boundary_opt

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Apr 12, 2022 •
edited
Loading

RepaintBoundary adds a rasterCache option to allow users to choose whether to cache the contents of RepaintBoundary in the raster cache. If the rasterCache of RepaintBoundary is set to true, it will improve the performance of complex list scrolling.

engine PR: flutter/engine#32615

fix #91648

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 12, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 12, 2022
This was referenced Apr 12, 2022
Closed
Closed
@ColdPaleLight ColdPaleLight changed the title Make RepaintBoundaries raster-cachable [WIP]Make RepaintBoundaries raster-cachable Apr 12, 2022
@goderbauer goderbauer marked this pull request as draft April 13, 2022 21:19
@goderbauer
Copy link
Member

goderbauer commented May 4, 2022

/cc @jonahwilliams who has looked a lot into repaint boundaries and raster caching recently..

@ColdPaleLight
Copy link
Member Author

ColdPaleLight commented May 16, 2022

Closing it, more context please see #91648 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TransformLayer should participate in raster caching

2 participants

@ColdPaleLight @goderbauer