[framework] use ImageFilter for zoom page transition#101786
[framework] use ImageFilter for zoom page transition#101786fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
f: material design
| child: ScaleTransition(scale: scaleTransition, child: child), | ||
| child: ScaleTransition( | ||
| scale: scaleTransition, | ||
| filterQuality: FilterQuality.none, |
There was a problem hiding this comment.
without knowing the background this seems strange. Should we add comments? Or is the idea that the docs on ScaleTransition cover this?
There was a problem hiding this comment.
What seems strange?
There was a problem hiding this comment.
Providing a filter quality to the scale transition
There was a problem hiding this comment.
Its documented on those widgets that it uses an ImageFilter if one is provided, though the documentation isn't extensive: https://api.flutter.dev/flutter/widgets/ScaleTransition/filterQuality.html
There was a problem hiding this comment.
I would have chosen FilterQuality.low. I don't think there will be much performance difference, but low will be smoother.
|
This pull request is not suitable for automatic merging in its current state.
|
This reverts commit 9984ebb.
|
This was reverted due to regressing numerous devicelab performance metrics. To reland, we'd likely need to wait until we have better cooperation among the opacity/image filter layers raster caching approach |
|
Yes, I saw that in my own prototype testing so I'm not surprised. Do we have an Issue filed for looking at the interaction between those 2 layers? I imagine it might be similar to the problems recently spotted with opacity interacting poorly with its own DL child: #101872 |
5 participants
Potentially fixes #100972 though we need full devicelab metrics.