Increased StandardMethodCodec's WriteBuffer start capacity#101860
Increased StandardMethodCodec's WriteBuffer start capacity#101860gaaclarke merged 3 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I'm not going to bother landing the benchmarks first. The savings are going to be similar to what we had with the other benchmarks. Although we'll probably benefit even more since method payloads are always going to be bigger. |
|
|
||
| import 'message_codec.dart'; | ||
|
|
||
| int _writeBufferStartCapacity = 64; |
|
This pull request is not suitable for automatic merging in its current state.
|
…01860) * Added standard method codec benchmark * increased writebuffer start size * added const
related: #101790
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.