SelectableText.rich: Fix TextSpan.style not merged into default text style#101911
Merged
justinmc merged 1 commit intoflutter:masterfrom Jul 6, 2022
Merged
Conversation
aba8add to
caf3159
Compare
Contributor
Author
Trying again. |
1410dd8 to
3cabf7f
Compare
Contributor
Author
|
cc: @HansMuller Another PR with failed Google testing, similar to the |
3cabf7f to
deeda49
Compare
deeda49 to
d9bc9f6
Compare
Contributor
|
It looks like this broke a few Scubas by changing line height or something like that. Some text has moved vertically by <20px. It looks acceptable to me, so I'm setting the Google tests to passing and merging this. Sorry for the delay @TahaTesser! |
This was referenced Jul 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2022
…efault text style (flutter/flutter#101911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 7, 2022
…efault text style (flutter/flutter#101911)
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
…ext style (flutter#101911) Properly merges the TextSpan.style of SelectableText.rich.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
…efault text style (flutter/flutter#101911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
…efault text style (flutter/flutter#101911)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #94042
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.