Reland "Add default selection style (#100719)"#101954
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Apr 15, 2022
Merged
Reland "Add default selection style (#100719)"#101954fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
This reverts commit 95e52da.
flutter-dashboard
bot
added
a: text input
Contributor
|
Looks like a resync is needed here. |
chunhtai
force-pushed
the
reland-selection
branch
from
5147bfe to
12facc0
Compare
Contributor
Author
|
@HansMuller The tests are passing now. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 21, 2022
This was referenced May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relands #100719
Internal test failed because the text selection theme in Theme widget does not override the default selection style correctly, The change is in the second commit.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.