Migrate `ListTile` unselected icon color to Material 3 by TahaTesser · Pull Request #102078 · flutter/flutter

TahaTesser · 2022-04-18T13:51:54Z

Updates ListTile default unselected icon color to Material 3.

Fixes #99400

Part of: #91605

Disabled icon specs from https://m3.material.io/components/buttons/specs

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

TahaTesser · 2022-07-18T10:21:23Z

Just resolved conflicts

darrenaustin

LGTM. Sorry for the lag on the response.

darrenaustin · 2022-08-30T22:56:01Z

packages/flutter/lib/src/material/list_tile.dart

Can we add a comment describing where the onSurface.withOpacity came from in the spec as this is not going through the usual token template system.

Thanks! I added a comment for the color, similar to the icon_button.dart docs.

flutter/packages/flutter/lib/src/material/icon_button.dart

Line 799 in d8fdb83

/// * disabled - Theme.colorScheme.onSurface(0.38)

The disabled case is handled above on line 589. So this seems to be returning the incorrect color for enabled, non-selected list tile icons.

line 589 disabled color is for disabled list_tile, this wasn't the fix.

The wording was wrong in the issue and PR, apologies.

By disabled, it means unselected. This is the author's code, ListTile is not disabled.

home: Scaffold( body: Column( children: const [ ListTile( leading: Icon(Icons.add_rounded), ), Icon(Icons.add_rounded), ] ), ),

The disabled case is handled above on line 589. So this seems to be returning the incorrect color for enabled, non-selected list tile icons.

In this case, I agree. At the time there were no specs for the list item but we have now and I can see the difference you're talking about.

I did a quick comparison here with Flutter vs Compose.

Flutter Compose

ListTile needs a complete migration, just for unselected color.

Filed #114006, please take a look.

Thanks, I think we'll be able to workaround this internally.

…/flutter#102078)

* 5bb612c Roll Flutter Engine from 14eb83a7d0bd to a8e97892ce25 (1 revision) (flutter/flutter#110938) * 798ce22 Roll Flutter Engine from a8e97892ce25 to 0a2f56cd025f (1 revision) (flutter/flutter#110940) * 5de91d9 Roll Flutter Engine from 0a2f56cd025f to b040ed90175b (1 revision) (flutter/flutter#110954) * 202f577 Roll Flutter Engine from b040ed90175b to b94120dfe9c6 (1 revision) (flutter/flutter#110960) * d8fdb83 Update `MaterialBanner` to support Material 3 (flutter/flutter#105957) * fbba194 Migrate `ListTile` disabled icon color to Material 3 (flutter/flutter#102078) * f625359 Roll Flutter Engine from b94120dfe9c6 to 5a2861e499d2 (1 revision) (flutter/flutter#110972) * eb154d5 Roll Flutter Engine from 5a2861e499d2 to 3ff25eb9081c (1 revision) (flutter/flutter#110974) * 0144110 Roll Flutter Engine from 3ff25eb9081c to 47c281f218db (1 revision) (flutter/flutter#110983) * b166390 Roll Flutter Engine from 47c281f218db to 25642a45a55e (1 revision) (flutter/flutter#110991) * bce9163 Roll Flutter Engine from 25642a45a55e to 7b3710878503 (1 revision) (flutter/flutter#110992) * 8cddac7 Roll Flutter Engine from 7b3710878503 to 3c0898c0dfed (1 revision) (flutter/flutter#110993) * 96345a4 Roll Flutter Engine from 3c0898c0dfed to ddc5bb330254 (1 revision) (flutter/flutter#110999) * 723b82e Feat: dSYM debug info for iOS & macOS builds (flutter/flutter#101586)

…/flutter#102078)

* 5bb612c Roll Flutter Engine from 14eb83a7d0bd to a8e97892ce25 (1 revision) (flutter/flutter#110938) * 798ce22 Roll Flutter Engine from a8e97892ce25 to 0a2f56cd025f (1 revision) (flutter/flutter#110940) * 5de91d9 Roll Flutter Engine from 0a2f56cd025f to b040ed90175b (1 revision) (flutter/flutter#110954) * 202f577 Roll Flutter Engine from b040ed90175b to b94120dfe9c6 (1 revision) (flutter/flutter#110960) * d8fdb83 Update `MaterialBanner` to support Material 3 (flutter/flutter#105957) * fbba194 Migrate `ListTile` disabled icon color to Material 3 (flutter/flutter#102078) * f625359 Roll Flutter Engine from b94120dfe9c6 to 5a2861e499d2 (1 revision) (flutter/flutter#110972) * eb154d5 Roll Flutter Engine from 5a2861e499d2 to 3ff25eb9081c (1 revision) (flutter/flutter#110974) * 0144110 Roll Flutter Engine from 3ff25eb9081c to 47c281f218db (1 revision) (flutter/flutter#110983) * b166390 Roll Flutter Engine from 47c281f218db to 25642a45a55e (1 revision) (flutter/flutter#110991) * bce9163 Roll Flutter Engine from 25642a45a55e to 7b3710878503 (1 revision) (flutter/flutter#110992) * 8cddac7 Roll Flutter Engine from 7b3710878503 to 3c0898c0dfed (1 revision) (flutter/flutter#110993) * 96345a4 Roll Flutter Engine from 3c0898c0dfed to ddc5bb330254 (1 revision) (flutter/flutter#110999) * 723b82e Feat: dSYM debug info for iOS & macOS builds (flutter/flutter#101586)

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 18, 2022

TahaTesser requested a review from HansMuller April 18, 2022 13:51

TahaTesser mentioned this pull request Apr 22, 2022

m3 material not being elevated #102296

Closed

darrenaustin self-requested a review April 28, 2022 19:58

HansMuller removed their request for review June 2, 2022 16:45

TahaTesser force-pushed the m3_list_tile_icon_color branch from fc81fa9 to 9d43cda Compare July 18, 2022 08:13

darrenaustin approved these changes Aug 30, 2022

View reviewed changes

TahaTesser added 2 commits September 5, 2022 11:13

Migrate ListTile disabled icon color to Material 3

25da95b

Add comment

cd8f031

TahaTesser force-pushed the m3_list_tile_icon_color branch from 9d43cda to cd8f031 Compare September 5, 2022 09:01

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 5, 2022

auto-submit bot merged commit fbba194 into flutter:master Sep 5, 2022

TahaTesser deleted the m3_list_tile_icon_color branch September 5, 2022 10:19

This was referenced Sep 5, 2022

Roll Flutter from 759d0e1b20c1 to bce91637c6db (63 revisions) flutter/packages#2565

Closed

Roll Flutter from 0e7257e698db to bce91637c6db (11 revisions) flutter/plugins#6360

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 5, 2022

fbba194 Migrate ListTile disabled icon color to Material 3 (flutter…

6b3c84a

…/flutter#102078)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022

fbba194 Migrate ListTile disabled icon color to Material 3 (flutter…

39c9c0e

…/flutter#102078)

This was referenced Sep 5, 2022

Roll Flutter from 0e7257e698db to 8cddac7d0298 (12 revisions) flutter/plugins#6363

Closed

Roll Flutter from 759d0e1b20c1 to 8cddac7d0298 (64 revisions) flutter/packages#2566

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 5, 2022

fbba194 Migrate ListTile disabled icon color to Material 3 (flutter…

85da3a8

…/flutter#102078)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022

fbba194 Migrate ListTile disabled icon color to Material 3 (flutter…

bf75207

…/flutter#102078)

This was referenced Sep 5, 2022

Roll Flutter from 0e7257e698db to 96345a4bb94c (13 revisions) flutter/plugins#6364

Closed

Roll Flutter from 759d0e1b20c1 to 96345a4bb94c (65 revisions) flutter/packages#2567

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 5, 2022

fbba194 Migrate ListTile disabled icon color to Material 3 (flutter…

2b67f18

…/flutter#102078)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022

fbba194 Migrate ListTile disabled icon color to Material 3 (flutter…

e50ade9

…/flutter#102078)

This was referenced Sep 5, 2022

Roll Flutter from 0e7257e698db to 723b82e4f0f3 (14 revisions) flutter/plugins#6365

Merged

Roll Flutter from 759d0e1b20c1 to 723b82e4f0f3 (66 revisions) flutter/packages#2568

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 5, 2022

fbba194 Migrate ListTile disabled icon color to Material 3 (flutter…

d6c655f

…/flutter#102078)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022

fbba194 Migrate ListTile disabled icon color to Material 3 (flutter…

0792083

…/flutter#102078)

engine-flutter-autoroll mentioned this pull request Sep 6, 2022

Roll Flutter from 759d0e1b20c1 to 96b72232bd76 (72 revisions) flutter/packages#2570

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022

fbba194 Migrate ListTile disabled icon color to Material 3 (flutter…

cea77b9

…/flutter#102078)

engine-flutter-autoroll mentioned this pull request Sep 6, 2022

Roll Flutter from 759d0e1b20c1 to 9dbc09de1fd7 (74 revisions) flutter/packages#2571

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022

fbba194 Migrate ListTile disabled icon color to Material 3 (flutter…

d04890e

…/flutter#102078)

engine-flutter-autoroll mentioned this pull request Sep 6, 2022

Roll Flutter from 759d0e1b20c1 to 27896a7b495a (76 revisions) flutter/packages#2572

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022

fbba194 Migrate ListTile disabled icon color to Material 3 (flutter…

c2be773

…/flutter#102078)

engine-flutter-autoroll mentioned this pull request Sep 6, 2022

Roll Flutter from 759d0e1b20c1 to c0354999a73f (77 revisions) flutter/packages#2573

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022

fbba194 Migrate ListTile disabled icon color to Material 3 (flutter…

3d9f2df

…/flutter#102078)

engine-flutter-autoroll mentioned this pull request Sep 6, 2022

Roll Flutter from 759d0e1b20c1 to 8da0432094c2 (78 revisions) flutter/packages#2574

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022

fbba194 Migrate ListTile disabled icon color to Material 3 (flutter…

89fd147

…/flutter#102078)

engine-flutter-autoroll mentioned this pull request Sep 7, 2022

Roll Flutter from 759d0e1b20c1 to 58ec4839159e (93 revisions) flutter/packages#2579

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2022

fbba194 Migrate ListTile disabled icon color to Material 3 (flutter…

93221c1

…/flutter#102078)

TahaTesser changed the title ~~Migrate ListTile disabled icon color to Material 3~~ Migrate ListTile unselected icon color to Material 3 Oct 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate `ListTile` unselected icon color to Material 3#102078

Migrate `ListTile` unselected icon color to Material 3#102078
auto-submit[bot] merged 2 commits intoflutter:masterfrom
NevercodeHQ:m3_list_tile_icon_color

TahaTesser commented Apr 18, 2022 •

edited

Loading

Uh oh!

TahaTesser commented Jul 18, 2022

Uh oh!

darrenaustin left a comment

Uh oh!

darrenaustin Aug 30, 2022

Uh oh!

TahaTesser Sep 5, 2022

Uh oh!

guidezpl Oct 24, 2022

Uh oh!

TahaTesser Oct 25, 2022 •

edited

Loading

Uh oh!

guidezpl Nov 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

TahaTesser commented Apr 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

TahaTesser commented Jul 18, 2022

Uh oh!

darrenaustin left a comment

Choose a reason for hiding this comment

Uh oh!

darrenaustin Aug 30, 2022

Choose a reason for hiding this comment

Uh oh!

TahaTesser Sep 5, 2022

Choose a reason for hiding this comment

Uh oh!

guidezpl Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

TahaTesser Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guidezpl Nov 1, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TahaTesser commented Apr 18, 2022 •

edited

Loading

TahaTesser Oct 25, 2022 •

edited

Loading