Skip to content

Revert "Configurable padding around FocusNodes in Scrollables" (#101772)#102313

Merged
godofredoc merged 1 commit intoflutter:flutter-2.13-candidate.2from
godofredoc:flutter-2.13-candidate.2
Apr 21, 2022
Merged

Revert "Configurable padding around FocusNodes in Scrollables" (#101772)#102313
godofredoc merged 1 commit intoflutter:flutter-2.13-candidate.2from
godofredoc:flutter-2.13-candidate.2

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Apr 21, 2022

CP: 17be6d7

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 21, 2022

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added f: focus Focus traversal, gaining or losing focus f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Apr 21, 2022
Piinks
Piinks approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XilaiZhang
XilaiZhang approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)

@godofredoc godofredoc merged commit 3904d60 into flutter:flutter-2.13-candidate.2 Apr 21, 2022
@godofredoc godofredoc deleted the flutter-2.13-candidate.2 branch April 21, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

+1 more reviewer

@XilaiZhang XilaiZhang XilaiZhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: focus Focus traversal, gaining or losing focus f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @Piinks @XilaiZhang