Skip to content

Put waitFor back in keyboard_textfield_test integration test#102315

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
LongCatIsLooong:textfield-test-switch-back-to-waitFor
Apr 21, 2022
Merged

Put waitFor back in keyboard_textfield_test integration test#102315
fluttergithubbot merged 2 commits intoflutter:masterfrom
LongCatIsLooong:textfield-test-switch-back-to-waitFor

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Apr 21, 2022 •
edited
Loading

The thing the caused the timeout in the past during the driver.waitFor call in the keyboard_textfield_test integration test might have been the blinking cursor. Without runUnsynchronized waitFor won't find the target widget until all animations are stopped. I'll revert this if it makes the test flaky again.

Related Issue
#96787

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 21, 2022
jmagman
jmagman approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might have been the blinking cursor

Oh interesting theory! Let's try it.

@fluttergithubbot fluttergithubbot merged commit 06314a0 into flutter:master Apr 21, 2022
@LongCatIsLooong LongCatIsLooong deleted the textfield-test-switch-back-to-waitFor branch April 21, 2022 20:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
4f03207 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
9e09e20 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
ebcc883 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
878993c 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
a868cf5 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
426eae1 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
39061af 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
45193f8 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
00732a7 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
e8b5243 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
f2cfaac 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
57a5473 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
ca8fc39 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
684fe1f 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
3a563de 
flutter/flutter#102315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
46e81ac 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
bb2d460 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
e97d851 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
d67dc3d 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
b1522d9 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
6772be9 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
f5c9e98 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 25, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
7b1c8e8 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
09211f0 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
d6fa194 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
71b9d58 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
62e725a 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
3db8fd4 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
9597a1a 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
8fc16b8 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
0f46162 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
9f11a80 
flutter/flutter#102315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
06314a0 Put waitFor back in keyboard_textfield_test integration test (
884c398 
flutter/flutter#102315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

@zanderso zanderso Awaiting requested review from zanderso

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LongCatIsLooong @jmagman @fluttergithubbot