Skip to content

[gen_keycode, RawKeyboard] Apply derived keyboard layout from Linux#102709

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
dkwingsmt:gen-key-goals-linux
May 12, 2022
Merged

[gen_keycode, RawKeyboard] Apply derived keyboard layout from Linux#102709
fluttergithubbot merged 2 commits intoflutter:masterfrom
dkwingsmt:gen-key-goals-linux

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Apr 28, 2022 •
edited
Loading

This PR implements the framework side for layout detection for Linux/GTK (engine flutter/engine#32665), among several related changed.

First, this PR adds support for specifiedLogicalKey to RawKeyEventDataLinux.

Second, this PR allows gen_keycode to generate layout goals for Linux. Both macOS and Linux now uses a separate data file layout_goals.json, instead of the previous strategy that uses all al-nums. This is because we needs one more key besides al-nums: IntlBackslash (an extra key found on European layouts.)

Third, the SDK version requirement of gen_keycode is bumped to 2.18 to allow super. syntax.

Last, as an unrelated change, this PR renamed a field in PhysicalKeyData from linuxScancode to evdevCode. The previous name is misleading, because Linux does not use this code. In fact, no systems use this code.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 28, 2022
@dkwingsmt dkwingsmt requested a review from gspencergoog April 28, 2022 02:21
@dkwingsmt dkwingsmt mentioned this pull request Apr 28, 2022
Closed
gspencergoog
gspencergoog approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 4, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dkwingsmt dkwingsmt force-pushed the gen-key-goals-linux branch from f4ac714 to 648a2c1 Compare May 11, 2022 23:12
@dkwingsmt dkwingsmt added a: text input Entering text in a text field or keyboard related problems waiting for tree to go green platform-linux Building on or for Linux specifically labels May 11, 2022
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 12, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 65ea767 into flutter:master May 12, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 12, 2022
@engine-flutter-autoroll
65ea767 [gen_keycode, RawKeyboard] Apply derived keyboard layout from…
3321b5e 
… Linux (flutter/flutter#102709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 12, 2022
@engine-flutter-autoroll
65ea767 [gen_keycode, RawKeyboard] Apply derived keyboard layout from…
5ed7567 
… Linux (flutter/flutter#102709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
65ea767 [gen_keycode, RawKeyboard] Apply derived keyboard layout from…
e754989 
… Linux (flutter/flutter#102709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
65ea767 [gen_keycode, RawKeyboard] Apply derived keyboard layout from…
460a285 
… Linux (flutter/flutter#102709)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. platform-linux Building on or for Linux specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dkwingsmt @fluttergithubbot @gspencergoog