Skip to content

CupertinoFormRow: Add an interactive example#103041

Merged
guidezpl merged 3 commits intoflutter:masterfrom
NevercodeHQ:cupertino_form_row_example
May 5, 2022
Merged

CupertinoFormRow: Add an interactive example#103041
guidezpl merged 3 commits intoflutter:masterfrom
NevercodeHQ:cupertino_form_row_example

Conversation

@TahaTesser
Copy link
Contributor

@TahaTesser TahaTesser commented May 4, 2022

part of #72926

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 4, 2022
@TahaTesser TahaTesser requested a review from guidezpl May 4, 2022 14:14
guidezpl
guidezpl reviewed May 4, 2022
View reviewed changes
packages/flutter/lib/src/cupertino/form_row.dart Outdated
Comment on lines 38 to 39
/// Creates a [CupertinoFormSection] containing a [CupertinoFormRow] with the
/// [prefix], [child], [helper] and [error] widgets.
Copy link
Member

@guidezpl guidezpl May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Creates a [CupertinoFormSection] containing a [CupertinoFormRow] with the
/// [prefix], [child], [helper] and [error] widgets.
/// Creates a [CupertinoFormSection] containing a [CupertinoFormRow] with
/// [prefix], [child], [helper] and [error] specified.

@guidezpl guidezpl merged commit 86e55df into flutter:master May 5, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2022
@engine-flutter-autoroll
86e55df CupertinoFormRow: Add an interactive example (flutter/flutt…
380c1ac 
…er#103041)
@TahaTesser TahaTesser deleted the cupertino_form_row_example branch May 5, 2022 06:59
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 5, 2022
@engine-flutter-autoroll
86e55df CupertinoFormRow: Add an interactive example (flutter/flutt…
65b73be 
…er#103041)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@TahaTesser @egramond
CupertinoFormRow: Add an interactive example (flutter#103041)
0ea3625 
* `CupertinoFormRow`: Add an interactive example

* fix typo

* Update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TahaTesser @guidezpl