Merged
Conversation
Contributor
There was a problem hiding this comment.
By convention, we put the child argument last.
Contributor
|
LGTM |
Require a Key on Input. Simplify the API for Focus.at() and Focus.moveTo(). Fixes flutter#236. This will require an e-mail to flutter-dev. Make Input grab focus onTap not onPointerDown. Fixes flutter#189. Complain when you use Focus.at() with two different GlobalKeys that are both in the tree at the same time. Fixes flutter#181. Add dartdocs for Focus.moveTo() and Focus.moveScopeTo().
TahaTesser
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Aug 13, 2020
Cirrus puts the PR description and commit message in environment variables. These messages tend to have non ASCII characters sometimes (like emojis), which triggers a Gradle bug (gradle/gradle#3117) resulting in Gradle crashing without a helpful error message. The real solution to this problem should be fixing the Gradle bug. The better workaround on the Flutter side would be to set a UTF8 locale on the Cirrus machine, but I have yet figured out how to do it. For now to avoid more people from hitting this I'm working around by temporarily unsetting the Cirrus environment variables with the PR description and commit message. A non ASCII character to make sure it works: 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require a Key on Input.
Simplify the API for Focus.at() and Focus.moveTo().
Fixes #236.
This will require an e-mail to flutter-dev.
Make Input grab focus onTap not onPointerDown.
Fixes #189.
Complain when you use Focus.at() with two different GlobalKeys that
are both in the tree at the same time.
Fixes #181.
Add dartdocs for Focus.moveTo() and Focus.moveScopeTo().