Skip to content

[flutter_releases] Cherry pick flutter-2.13-candidate.7 changes (#10…#103374

Merged
muditatandon merged 3 commits intoflutter:flutter-2.13-candidate.10from
muditatandon:flutter-2.13-candidate.10
May 9, 2022
Merged

[flutter_releases] Cherry pick flutter-2.13-candidate.7 changes (#10…#103374
muditatandon merged 3 commits intoflutter:flutter-2.13-candidate.10from
muditatandon:flutter-2.13-candidate.10

Conversation

@muditatandon
Copy link

@muditatandon muditatandon commented May 9, 2022 •
edited
Loading

…3206)

This reverts commit 6ea4aef.

  • Roll engine with Cps

  • Fix engine hash

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@muditatandon
[flutter_releases] Cherry pick flutter-2.13-candidate.7 changes (flut…
e5d5f69 
…ter#103206)

* Revert "Fix jumping when doing long press for selecting text (flutter#102270)" (flutter#103142)

This reverts commit 6ea4aef.

* Roll engine with Cps

* Fix engine hash
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 9, 2022

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. labels May 9, 2022
@muditatandon muditatandon requested a review from CaseyHillers May 9, 2022 22:51
@CaseyHillers CaseyHillers mentioned this pull request May 9, 2022
Closed
@muditatandon muditatandon merged commit 93a41bc into flutter:flutter-2.13-candidate.10 May 9, 2022
CaseyHillers
CaseyHillers reviewed May 10, 2022
View reviewed changes
bin/internal/engine.version
@@ -1 +1 @@
07584c64bb7ba8d9e79214c3667cdb16cfa67923
74ac1de5d4f70d6db6cc7f99f6f259a7d073c3ab
Copy link
Contributor

@CaseyHillers CaseyHillers May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this didn't roll the engine. It should've been 3c78298d0b483984fbb27849c597db84a12c2c19

See https://github.com/flutter/engine/commits/flutter-2.13-candidate.10 for the latest hash.

However, this did roll the 2.13.9 hash, which is the exact same artifacts. So no change on our end is necessary.

@muditatandon muditatandon deleted the flutter-2.13-candidate.10 branch May 13, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

+1 more reviewer

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@muditatandon @CaseyHillers @fluttergithubbot