Skip to content

FloatingActionButton: add themeable mouse cursor#103473

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jpnurmi:fab-theme-mouse-cursor2
Jul 27, 2022
Merged

FloatingActionButton: add themeable mouse cursor#103473
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jpnurmi:fab-theme-mouse-cursor2

Conversation

@jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented May 11, 2022

Allow themes to override FloatingActionButton's mouse cursor.

This is #96714 reopened as a new PR and is a partial fix to #88371.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 11, 2022
@jpnurmi
Copy link
Member Author

jpnurmi commented May 11, 2022

Regardless of numerous upstream merges, #96714 has been repeatedly failing on unrelated customer tests for a couple of months. This is an attempt to run through the CI with the same changes on a fresh and clean base.

@jpnurmi
Copy link
Member Author

jpnurmi commented May 12, 2022

@werainkhatri This PR replaces #96714 which refuses to pass customer this.

werainkhatri
werainkhatri reviewed May 12, 2022
View reviewed changes
Copy link
Member

@werainkhatri werainkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird how that happens... maybe it should be informed to the infra team?

anyway, this LGTM with a few nits.

@darrenaustin darrenaustin self-requested a review May 13, 2022 21:20
@Hixie
Copy link
Contributor

Hixie commented Jul 26, 2022

@jpnurmi Will you be able to continue working on this? It's totally fine if not; we can take it over (though it might take longer). I'm just asking because I'm trying to clean out our review queue.

jpnurmi
jpnurmi commented Jul 27, 2022
View reviewed changes
Copy link
Member Author

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had left answers but I guess I never pressed the button. Anyway, I have merged the latest main.

@werainkhatri
Copy link
Member

werainkhatri commented Jul 27, 2022 •
edited
Loading

@jpnurmi looks like there are a few failing tests still, can you take another look? thanks!

@jpnurmi jpnurmi force-pushed the fab-theme-mouse-cursor2 branch from 8592480 to 48b6193 Compare July 27, 2022 15:12
@jpnurmi
Copy link
Member Author

jpnurmi commented Jul 27, 2022

Rebase helped to get the latest customer tests run.

werainkhatri
werainkhatri approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@werainkhatri werainkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@werainkhatri werainkhatri added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 27, 2022
@auto-submit auto-submit bot merged commit fbb3036 into flutter:master Jul 27, 2022
@jpnurmi jpnurmi deleted the fab-theme-mouse-cursor2 branch July 27, 2022 18:09
@jpnurmi jpnurmi mentioned this pull request Jul 27, 2022
Open
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 28, 2022
@engine-flutter-autoroll
fbb3036 FloatingActionButton: add themeable mouse cursor (flutter/flu…
f30c714 
…tter#103473)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2022
@engine-flutter-autoroll
fbb3036 FloatingActionButton: add themeable mouse cursor (flutter/flu…
1985b71 
…tter#103473)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@jpnurmi @camsim99
FloatingActionButton: add themeable mouse cursor (flutter#103473)
450168d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@werainkhatri werainkhatri werainkhatri approved these changes

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpnurmi @Hixie @werainkhatri