use immutable buffer for loading asset images#103496
Merged
fluttergithubbot merged 29 commits intoflutter:masterfrom May 27, 2022
Merged
use immutable buffer for loading asset images#103496fluttergithubbot merged 29 commits intoflutter:masterfrom
fluttergithubbot merged 29 commits intoflutter:masterfrom
Conversation
added 2 commits
May 11, 2022 08:40
flutter-dashboard
bot
added
f: scrolling
jonahwilliams
changed the title
flutter-dashboard
bot
added
the
tool
added 2 commits
May 11, 2022 13:24
jonahwilliams
commented
May 11, 2022
| uses-material-design: true | ||
| assets: | ||
| - icon/ | ||
| - icon/test.png |
Contributor
Author
There was a problem hiding this comment.
This was indented wrong and never loaded the asset
Member
There was a problem hiding this comment.
Why didn't the associated test above fail, then? It seems to claim that it tests whether the asset loads....
Contributor
Author
There was a problem hiding this comment.
The previously used asset loader workaround does not throw errors in the same way as the regular asset loader: https://github.com/flutter/flutter/blob/master/packages/flutter_test/lib/src/_binding_io.dart#L34
added 2 commits
May 11, 2022 14:16
…er into use_immutable_buffer
Contributor
Author
|
TBD whether or not we should leave the old methods implemented. I intended to do further testing to see if there are any places in google that uses the load method directly |
flutter-dashboard
bot
added
a: accessibility
10 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 31, 2022
This was referenced May 31, 2022
Member
|
SkiaPerf microbenchmark results look good: https://flutter-flutter-perf.skia.org/e/?begin=1651498148&end=1654001288&keys=Xffbf390d4558490c4e2bc4416f712061&requestType=0&xbaroffset=29184 |
This was referenced May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading asset images via the immutable buffer should both improve loading performance by removing a copy and reduce GC pressure by avoiding a round-trip of the compressed image bytes through the dart heap.
This is the start of a breaking change, this PR is intended to be non-breaking (though it currently isn't, for testing purposes)
To make this change less-breaking, a default implementation of the loadBuffer is added to imageProvider, that returns a const instance of a no-op image stream. We detect this case and fallback to the old load method conditionally, allowing image providers time to migrate.