Add VoidCallbackAction and VoidCallbackIntent#103518
Merged
gspencergoog merged 2 commits intoflutter:masterfrom May 17, 2022
Merged
Add VoidCallbackAction and VoidCallbackIntent#103518gspencergoog merged 2 commits intoflutter:masterfrom
gspencergoog merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
framework
goderbauer
approved these changes
May 13, 2022
Comment on lines
-527
to
-528
| /// | ||
| /// Must not be null. |
Contributor
Author
There was a problem hiding this comment.
Yes, but it's non-nullable, so I assume that gives enough implicit documentation that it can't be null.
I realize that someone could be using a weak nullability app, though. I'll reinstate it.
gspencergoog
force-pushed
the
void_callback_action
branch
from
93932aa to
f09d29f
Compare
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
This was referenced May 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a simple
VoidCallbackActionandVoidCallbackIntentthat allows configuring an intent that will invoke a void callback when the intent is sent to the action subsystem. This allows binding a shortcut directly to a void callback in aShortcutswidget.I also added an instance of
VoidCallbackActionto the default actions so that simply binding a shortcut to aVoidCallbackIntentworks anywhere in the app, and you don't need to add aVoidCallbackActionat the top of your app to make it work.Tests