Skip to content

Delete native_ui_tests_ios#103727

Merged
jmagman merged 1 commit intoflutter:masterfrom
jmagman:native_ui_tests_ios
May 16, 2022
Merged

Delete native_ui_tests_ios#103727
jmagman merged 1 commit intoflutter:masterfrom
jmagman:native_ui_tests_ios

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented May 13, 2022 •
edited
Loading

Should have been included in #103666.

First part of #95193

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman requested a review from keyonghan as a code owner May 13, 2022 17:38
@jmagman jmagman self-assigned this May 13, 2022
@jmagman jmagman mentioned this pull request May 13, 2022
Merged
@christopherfujino
Copy link
Contributor

christopherfujino commented May 13, 2022

Won't this still be red until the ci_yaml roller finishes?

@jmagman
Copy link
Member Author

jmagman commented May 13, 2022

#103666 was reverted with #103726, this should merge first.

@jmagman jmagman requested a review from christopherfujino May 13, 2022 17:43
@christopherfujino
Copy link
Contributor

christopherfujino commented May 13, 2022

To follow-up from discord discussion, I landed my revert instead and this deprecation will be re-landed in two PRs; the first removing the builders, the second deleting the test code

@keyonghan
Copy link
Contributor

keyonghan commented May 13, 2022

@christopherfujino I believe this is safe to land. Any concern here to close this PR?

@jmagman jmagman reopened this May 13, 2022
@christopherfujino
Copy link
Contributor

christopherfujino commented May 13, 2022

Oops, sorry, yeah, we should land this

@jmagman
Copy link
Member Author

jmagman commented May 13, 2022

I landed my revert instead and this deprecation will be re-landed in two PRs; the first removing the builders

This would be the first PR then.

christopherfujino
christopherfujino approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

keyonghan
keyonghan approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman mentioned this pull request May 13, 2022
Closed
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 13, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 13, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jmagman jmagman merged commit 5ce07af into flutter:master May 16, 2022
@jmagman jmagman deleted the native_ui_tests_ios branch May 16, 2022 22:59
@jmagman jmagman mentioned this pull request May 16, 2022
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2022
@engine-flutter-autoroll
5ce07af Delete native_ui_tests_ios (flutter/flutter#103727)
fa0473a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
5ce07af Delete native_ui_tests_ios (flutter/flutter#103727)
79900fd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 17, 2022
@engine-flutter-autoroll
5ce07af Delete native_ui_tests_ios (flutter/flutter#103727)
2d2e2e9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
5ce07af Delete native_ui_tests_ios (flutter/flutter#103727)
e2b888d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
5ce07af Delete native_ui_tests_ios (flutter/flutter#103727)
7cec9fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmagman @christopherfujino @keyonghan @fluttergithubbot