add noSuchMethod to _MulticastCanvas to unblock smoke testing against forthcoming new getTransform/Clip methods#103737
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
framework
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
@dnfield to confirm we need these APIs, I lost track of the discussion a bit 😄
|
(landing this would be harmless though, so still LGTM) |
| _screenshot.clipRect(rect, clipOp: clipOp, doAntiAlias: doAntiAlias); | ||
| } | ||
|
|
||
| Rect getCurrentClipBounds() { |
There was a problem hiding this comment.
maybe add a trivial test that checks these are Rect.zero and Identity?
There was a problem hiding this comment.
And then amend the tests when they return actual values?
There was a problem hiding this comment.
if that would break the roll, then probably not. i'd say its tested by way of allowing the engine PR to land by unbreaking those tests. You could also implement noSuchMethod
There was a problem hiding this comment.
I didn't think of NSM...
There was a problem hiding this comment.
May want to have an @override on these with an ignore so that the analyzer will ignore it now but accept it when they're actually overriding something.
NSM is fine too
There was a problem hiding this comment.
I went the NSM route as it's simpler. We might want to consider leaving it there permanently so that this only becomes a problem when new testing code needs the new implementations (in these screenshot tests).
flar
changed the title
… against forthcoming new getTransform/Clip methods (flutter/flutter#103737)
… against forthcoming new getTransform/Clip methods (flutter/flutter#103737)
… against forthcoming new getTransform/Clip methods (flutter/flutter#103737)
… against forthcoming new getTransform/Clip methods (flutter/flutter#103737)
… against forthcoming new getTransform/Clip methods (flutter/flutter#103737)
4 participants
The noSuchMethod override prevents the compiler from complaining while we roll the new methods over from the engine.