Add const MaterialStatePropertyAll class.#104127
Merged
darrenaustin merged 2 commits intoflutter:masterfrom May 19, 2022
darrenaustin:material_state_all
Merged
Add const MaterialStatePropertyAll class.#104127darrenaustin merged 2 commits intoflutter:masterfrom darrenaustin:material_state_all
MaterialStatePropertyAll class.#104127darrenaustin merged 2 commits intoflutter:masterfrom
darrenaustin:material_state_all
Conversation
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 19, 2022
Contributor
|
@darrenaustin |
Contributor
Author
Thanks, but all credit to @HansMuller for the idea. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you want to create a
MaterialStatePropertythat always returns the same value regardless of the current states, you could use the.allstatic method:However this can be a const value which makes it harder to use with const ButtonStyles and other structures that could be const otherwise.
This PR adds a new
MaterialStatePropertyAllclass that allows you to convert the above code to:Which can then be used in other const structures.
We may deprecate
MaterialStateProperty.allin the future, but didn't want to do this without a dart fix for it. As it turns out, this isn't a case that can be currently handled by dart fix. When it is, we will probably deprecate it.Pre-launch Checklist
///).