Skip to content

Make it possible to build apps for Android versions still in preview#104172

Closed
bartekpacia wants to merge 5 commits intoflutter:masterfrom
bartekpacia:fix_android_tiramisu_build_failing
Closed

Make it possible to build apps for Android versions still in preview#104172
bartekpacia wants to merge 5 commits intoflutter:masterfrom
bartekpacia:fix_android_tiramisu_build_failing

Conversation

@bartekpacia
Copy link
Member

@bartekpacia bartekpacia commented May 19, 2022 •
edited
Loading

Fixes #104170

It makes it possible to use non-integer compileSdkVersion in app-level build.gradle file.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 19, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 19, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla
Copy link

google-cla bot commented May 19, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@bartekpacia bartekpacia marked this pull request as draft May 19, 2022 10:29
@bartekpacia
make app's android build work on Tiramisu
32a4260 
with:
- compileSdkVersion "android-Tiramisu"
- targetSdkVersion 33
@bartekpacia
create resolveSdkVersion()
e74f3c6
@bartekpacia
remove printlns
93a00cc
@bartekpacia bartekpacia mentioned this pull request May 19, 2022
Closed
bernaferrari
bernaferrari reviewed May 19, 2022
View reviewed changes
bartekpacia
bartekpacia commented May 24, 2022
View reviewed changes
packages/flutter_tools/gradle/flutter.gradle Outdated
Copy link
Member Author

@bartekpacia bartekpacia May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blasten I saw you suggested adding this in https://github.com/flutter/flutter/pull/92451/files#r743925947, so I did :P

@bartekpacia bartekpacia requested a review from blasten May 24, 2022 19:22
@bartekpacia bartekpacia changed the title make app's android build work on Tiramisu Make it possible to build apps on Android versions still in preview May 24, 2022
@bartekpacia bartekpacia changed the title Make it possible to build apps on Android versions still in preview Make it possible to build apps for Android versions still in preview May 24, 2022
@bartekpacia
implement suggested solution
64f8b5f 
If compileSdkVersion isn't an int, then detectLowCompileSdkVersionOrNdkVersion just returns
@bartekpacia
Copy link
Member Author

bartekpacia commented May 24, 2022 •
edited
Loading

@blasten

  1. Should I get a test exemption from Hixie or should I write tests for it?
  2. Should I do the same for plugins? See here

@GaryQian GaryQian mentioned this pull request May 25, 2022
Merged
@blasten
Copy link

blasten commented May 31, 2022

#104662 fixed this issue. Thanks for the contribution

@blasten blasten closed this May 31, 2022
@bartekpacia bartekpacia deleted the fix_android_tiramisu_build_failing branch May 31, 2022 21:47
@gmackall gmackall mentioned this pull request Aug 4, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bernaferrari bernaferrari bernaferrari left review comments

@blasten blasten Awaiting requested review from blasten

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[flutter_tools] Can't build apps targeting Android 13 Tiramisu (API level 33)

3 participants

@bartekpacia @blasten @bernaferrari