Moving linux vm builds to Ubuntu.#104294
Conversation
Moving tests that have successfully run on Ubuntu machines in staging. Bug:102406
yusuf-goog
changed the title
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I think the new HTML goldens look acceptable. For some reason in the past the HTML renderer used to render actual CJK characters, while all other platforms would render placeholders. The new golden is now showing placeholders for the HTML renderer, consistent with other platforms. |
4 participants
Moving tests that have successfully run on Ubuntu machines in staging.
Bug:102406
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.