Roll Plugins from f4ca73237db8 to 99aa799ea07a (11 revisions) by engine-flutter-autoroll · Pull Request #104430 · flutter/flutter

engine-flutter-autoroll · 2022-05-23T18:11:10Z

flutter/plugins@f4ca732...58478a5

2022-05-23 [email protected] [google_maps_flutter] Fix prefer_const_literals_to_create_immutables (flutter/plugins#5811)
2022-05-23 [email protected] [google_maps_flutter] Updates platform interface to new analysis options (flutter/plugins#5793)
2022-05-23 [email protected] [Camera] Return all possible cameras on iOS (flutter/plugins#5636)
2022-05-23 [email protected] [google_sign_in, in_app_purchase_android] Add availability to mock models (flutter/plugins#5642)
2022-05-21 [email protected] Roll Flutter from de7c23e to ec20ea8 (1 revision) (flutter/plugins#5805)
2022-05-21 [email protected] Roll Flutter from b8b0c80 to de7c23e (1 revision) (flutter/plugins#5804)
2022-05-21 [email protected] Roll Flutter from 4654fd0 to b8b0c80 (1 revision) (flutter/plugins#5803)
2022-05-21 [email protected] Roll Flutter from 6aaabf6 to 4654fd0 (2 revisions) (flutter/plugins#5802)
2022-05-21 [email protected] Roll Flutter from 1e10cec to 6aaabf6 (1 revision) (flutter/plugins#5800)
2022-05-21 [email protected] Roll Flutter from 1e1f4bc to 1e10cec (6 revisions) (flutter/plugins#5799)
2022-05-21 [email protected] Roll Flutter from a4a8e73 to 1e1f4bc (65 revisions) (flutter/plugins#5795)
2022-05-20 [email protected] [google_sign_in] Suppress deprecation warnings (flutter/plugins#5049)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-plugins-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fluttergithubbot · 2022-05-23T19:13:07Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac dart_plugin_registry_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac run_release_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

fluttergithubbot · 2022-05-23T20:18:09Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac dart_plugin_registry_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac run_release_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

fluttergithubbot · 2022-05-23T21:23:09Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac dart_plugin_registry_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac run_release_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

engine-flutter-autoroll · 2022-05-23T21:25:05Z

Commit queue failed; closing this roll.

…to mock models (flutter/plugins#5642)

…s#5636)

…lysis options (flutter/plugins#5793)

jmagman · 2022-05-23T22:05:13Z

Reopening and rebasing on main, will hopefully close #104453 by picking up flutter/plugins#5793

jmagman · 2022-05-23T22:13:43Z

Adding reviewers so I can merge manually when https://ci.chromium.org/p/flutter/builders/try/Linux%20flutter_plugins/26159 passes.

christopherfujino

LGTM

bparrishMines

LGTM

jmagman · 2022-05-23T22:19:48Z

https://ci.chromium.org/p/flutter/builders/try/Linux%20flutter_plugins/26159 still failed:

   info - example/integration_test/google_maps_controller_test.dart:148:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_controller_test.dart:149:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_controller_test.dart:162:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_controller_test.dart:163:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_controller_test.dart:176:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_controller_test.dart:177:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_controller_test.dart:190:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_controller_test.dart:191:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:236:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:237:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:246:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:247:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:256:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:257:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:266:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:267:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables

bparrishMines · 2022-05-23T22:24:30Z

Yea, it looks like google_maps_flutter_web was missed in the PR: flutter/plugins#5793

bparrishMines · 2022-05-23T22:29:43Z

I can create a PR, but I'm not sure why our CI didn't catch this

jmagman · 2022-05-23T22:45:42Z

I can create a PR, but I'm not sure why our CI didn't catch this

Actually I already got it in flutter/plugins#5811.
Updated this roll to that SHA.

jmagman · 2022-05-23T23:01:11Z

Woot analysis passed https://ci.chromium.org/p/flutter/builders/try/Linux%20plugin_test/16601.
Merging.

…flutter#104430)

…r#104430)

…flutter#104430)

engine-flutter-autoroll added the waiting for tree to go green label May 23, 2022

fluttergithubbot removed the waiting for tree to go green label May 23, 2022

engine-flutter-autoroll added the waiting for tree to go green label May 23, 2022

fluttergithubbot removed the waiting for tree to go green label May 23, 2022

engine-flutter-autoroll added the waiting for tree to go green label May 23, 2022

fluttergithubbot removed the waiting for tree to go green label May 23, 2022

engine-flutter-autoroll closed this May 23, 2022

jmagman reopened this May 23, 2022

jmagman mentioned this pull request May 23, 2022

google_maps_flutter_web has prefer_const_literals_to_create_immutables info warnings #104453

Closed

engine-flutter-autoroll added 11 commits May 23, 2022 15:04

aaaa81c67 [google_sign_in] Suppress deprecation warnings (flutter/p…

87eee6c

…lugins#5049)

206694975 Roll Flutter from a4a8e73 to 1e1f4bc (65 revisions) (flutte…

04910c3

…r/plugins#5795)

7f349dc99 Roll Flutter from 1e1f4bc to 1e10cec (6 revisions) (flutter…

0002331

…/plugins#5799)

ea56ff0d5 Roll Flutter from 1e10cec to 6aaabf6 (1 revision) (flutter/…

0dc95df

…plugins#5800)

945954952 Roll Flutter from 6aaabf6 to 4654fd0 (2 revisions) (flutter…

6820031

…/plugins#5802)

407f4e30a Roll Flutter from 4654fd0 to b8b0c80 (1 revision) (flutter/…

7d99c9a

…plugins#5803)

f7052de7b Roll Flutter from b8b0c80 to de7c23e (1 revision) (flutter/…

0e1c803

…plugins#5804)

e360a5fe4 Roll Flutter from de7c23e to ec20ea8 (1 revision) (flutter/…

464f6bd

…plugins#5805)

ef9effec5 [google_sign_in, in_app_purchase_android] Add availability …

c0c99cf

…to mock models (flutter/plugins#5642)

bbae271cf [Camera] Return all possible cameras on iOS (flutter/plugin…

6328031

…s#5636)

99aa799ea [google_maps_flutter] Updates platform interface to new ana…

ec1f257

…lysis options (flutter/plugins#5793)

jmagman force-pushed the flutter-plugins-flutter-autoroll-3f3e0224-6fd5-4bfb-8621-2e75b4f2dade-1653329467 branch from d5bd244 to ec1f257 Compare May 23, 2022 22:04

jmagman requested review from bparrishMines and christopherfujino May 23, 2022 22:13

christopherfujino approved these changes May 23, 2022

View reviewed changes

bparrishMines approved these changes May 23, 2022

View reviewed changes

bparrishMines mentioned this pull request May 23, 2022

[google_maps_flutter_web] Use const constructors in the example integration tests flutter/plugins#5812

Closed

11 tasks

[google_maps_flutter] Fix prefer_const_literals_to_create_immutables

90bbaa3

jmagman merged commit 7ece8f9 into flutter:master May 23, 2022

engine-flutter-autoroll mentioned this pull request May 23, 2022

Roll Flutter from 0015ed2b7541 to 7ece8f9f9435 (1 revision) flutter/packages#2044

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2022

7ece8f9 Roll Plugins from f4ca732 to 99aa799 (11 revisions) (flutter/…

232371a

…flutter#104430)

engine-flutter-autoroll mentioned this pull request May 23, 2022

Roll Flutter from ec20ea80ad98 to 7ece8f9f9435 (3 revisions) flutter/plugins#5813

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 23, 2022

7ece8f9 Roll Plugins from f4ca732 to 99aa799 (11 revisions) (flutter/…

5ef1f27

…flutter#104430)

engine-flutter-autoroll deleted the flutter-plugins-flutter-autoroll-3f3e0224-6fd5-4bfb-8621-2e75b4f2dade-1653329467 branch May 30, 2022 18:24

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

Roll Plugins from f4ca73237db8 to 99aa799ea07a (11 revisions) (flutte…

cd4996e

…r#104430)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022

7ece8f9 Roll Plugins from f4ca732 to 99aa799 (11 revisions) (flutter/…

95687ed

…flutter#104430)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022

7ece8f9 Roll Plugins from f4ca732 to 99aa799 (11 revisions) (flutter/…

3521e46

…flutter#104430)

Conversation

engine-flutter-autoroll commented May 23, 2022 • edited by jmagman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fluttergithubbot commented May 23, 2022

Uh oh!

fluttergithubbot commented May 23, 2022

Uh oh!

fluttergithubbot commented May 23, 2022

Uh oh!

engine-flutter-autoroll commented May 23, 2022

Uh oh!

jmagman commented May 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman commented May 23, 2022

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman commented May 23, 2022

Uh oh!

bparrishMines commented May 23, 2022

Uh oh!

bparrishMines commented May 23, 2022

Uh oh!

jmagman commented May 23, 2022

Uh oh!

jmagman commented May 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

engine-flutter-autoroll commented May 23, 2022 •

edited by jmagman

Loading

jmagman commented May 23, 2022 •

edited

Loading