Skip to content

Use curly_braces_in_flow_control_structures for rendering#104611

Merged
guidezpl merged 3 commits intoflutter:masterfrom
guidezpl:curlyyyyyy
May 25, 2022
Merged

Use curly_braces_in_flow_control_structures for rendering#104611
guidezpl merged 3 commits intoflutter:masterfrom
guidezpl:curlyyyyyy

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented May 25, 2022

Part of #104498

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels May 25, 2022
@guidezpl guidezpl requested a review from goderbauer May 25, 2022 14:25
@guidezpl guidezpl mentioned this pull request May 25, 2022
Closed
11 tasks
@guidezpl guidezpl marked this pull request as ready for review May 25, 2022 15:16
goderbauer
goderbauer approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Hixie
Copy link
Contributor

Hixie commented May 25, 2022

test-exempt: formatting change

@guidezpl guidezpl merged commit e71eb18 into flutter:master May 25, 2022
@guidezpl guidezpl deleted the curlyyyyyy branch May 25, 2022 17:58
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2022
@engine-flutter-autoroll
e71eb18 Use curly_braces_in_flow_control_structures for rendering (…
27dd759 
…flutter/flutter#104611)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 25, 2022
@engine-flutter-autoroll
e71eb18 Use curly_braces_in_flow_control_structures for rendering (…
e38013b 
…flutter/flutter#104611)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 25, 2022
@engine-flutter-autoroll
e71eb18 Use curly_braces_in_flow_control_structures for rendering (…
161198f 
…flutter/flutter#104611)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@guidezpl @camsim99
Use curly_braces_in_flow_control_structures for rendering (flutte…
7f4bc4a 
…r#104611)

* Use `curly_braces_in_flow_control_structures` for `rendering`

* fix comments

* fix dangling
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
e71eb18 Use curly_braces_in_flow_control_structures for rendering (…
12e6f58 
…flutter/flutter#104611)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
e71eb18 Use curly_braces_in_flow_control_structures for rendering (…
2ad09e7 
…flutter/flutter#104611)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guidezpl @Hixie @goderbauer