Skip to content

Fix issues running integration tests through DAP debug adapter#104618

Merged
DanTup merged 2 commits intoflutter:masterfrom
DanTup:add-dap-tests-for-integration-tests
May 26, 2022
Merged

Fix issues running integration tests through DAP debug adapter#104618
DanTup merged 2 commits intoflutter:masterfrom
DanTup:add-dap-tests-for-integration-tests

Conversation

@DanTup
Copy link
Contributor

@DanTup DanTup commented May 25, 2022

These adapters were incorrectly trying to connect a DDS instance even when Flutter would create its own, which caused issues when running integration tests through the test DAP. This change disables DDS in the DAP layer and leaves it to Flutter (although it will pass along --no-dds to Flutter if provided to the DAP process to allow it to still be disabled there if required) + adds explicit tests for integration tests (that require this change to pass).

Also fixes an issue where we would unnecessarily connect the VM Service for tests even in 'noDebug' mode because the assumption that 'vmServiceUri' would be null in the test.startedProcess event when not using --start-paused is no longer correct.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@DanTup
Fix issues running integration tests through DAP
58fbe11 
These adapters were incorrectly trying to connect a DDS instance even when Flutter would create its own. This change disables DDS in the DAP layer and leaves it to Flutter (although it passes `--no-dds` on to Flutter if provided to the DAP process).

Also fixes an issue where we would unnecessarily connect the VM Service for tests even in 'noDebug' mode because of a change/fix that now includes a 'vmServiceUri' in the `test.startedProcess` event.
@DanTup DanTup requested a review from christopherfujino May 25, 2022 15:01
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 25, 2022
christopherfujino
christopherfujino approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one test nit, otherwise LGTM

@DanTup DanTup merged commit 1470203 into flutter:master May 26, 2022
@DanTup DanTup deleted the add-dap-tests-for-integration-tests branch May 26, 2022 08:36
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
154a592 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
13eb8cb 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
e664c5c 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
c3a42cb 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
d3f2052 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
79023b4 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
3424204 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
35b5316 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
0e43590 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
fa62378 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
71a2cf7 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
18935ea 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
bd93917 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
386563e 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
875b3d3 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
24c25cd 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
35473fb 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
0bdf338 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
352d309 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
02fcaae 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
0ca7f16 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
cbc0fbd 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
4f2570c 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
c517d04 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
8359a25 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
fb6b637 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
7c29aca 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
912195e 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
d8cd8ee 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
8781a7a 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
d382f2b 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
1fc2e42 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
9a07fd1 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
544e487 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
0fcf996 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
7fc7de0 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
9a50fbd 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
221850d 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
fb6a8be 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
d6788cd 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
42b8928 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
3eb1e4d 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
91a2198 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
70c4221 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
290e74b 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
51bee9c 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
823f6f6 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
e0eadf9 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
dc61509 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
03eaf08 
flutter/flutter#104618)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
1470203 Fix issues running integration tests through DAP debug adapter (
4171989 
flutter/flutter#104618)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DanTup @christopherfujino