Move corrupted zip to a separate handler and ask user#105054
Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom Jun 3, 2022
Merged
Move corrupted zip to a separate handler and ask user#105054fluttergithubbot merged 4 commits intoflutter:masterfrom
fluttergithubbot merged 4 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
blasten
force-pushed
the
remove_gradle_removal
branch
from
0c89547 to
bb6286e
Compare
camsim99
approved these changes
Jun 3, 2022
Contributor
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
LGTM! Just one question.
| final Directory directory = globals.fs.directory(globals.fs.path.join(homeDir, '.gradle')); | ||
| ErrorHandlingFileSystem.deleteIfExists(directory, recursive: true); | ||
| if (homeDir == null) { | ||
| globals.logger.printStatus("Could not delete .gradle directory because there isn't a HOME env variable"); |
Contributor
There was a problem hiding this comment.
Out of complete curiosity, how common would it be for someone to have moved it since the home directory is the default? If decently common, would it be reasonable to allow them provide the path to delete it?
Author
There was a problem hiding this comment.
I don't think it is common. The user would need to do something different than what Gradle does by default: https://docs.gradle.org/current/userguide/directory_layout.html#dir:gradle_user_home
I'm also not sure if it's possible.- I'm not aware of a GRADLE_HOME variable or similar that would inform Gradle where this directory is.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 7, 2022
|
On which Channel is this fix on because am still getting a re-download of gradle with flutter 3.0.2 - stable channel |
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
|
Still getting this issue |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
|
I am still getting this error on flutter 3.0.4 |
Contributor
|
@Genialngash @ziakhan110 @kudak3 Are any of you receiving the warning "Your .gradle directory under the home directory might be corrupted." before Gradle redownloads? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89959