Text handle drag swap on Apple platforms#105069
Merged
justinmc merged 5 commits intoflutter:masterfrom Jun 10, 2022
Merged
Conversation
flutter-dashboard
bot
added
a: text input
LongCatIsLooong
approved these changes
Jun 2, 2022
Contributor
LongCatIsLooong
left a comment
LongCatIsLooong
left a comment
There was a problem hiding this comment.
If you swap the handles, the same gesture recognizer callback is still registered to the same handle under the touch point is it?
| // On Apple platforms, dragging the base handle makes it the extent. | ||
| case TargetPlatform.iOS: | ||
| case TargetPlatform.macOS: | ||
| final int endOffset = math.max( |
Contributor
There was a problem hiding this comment.
nit: _selection.end?
Contributor
Author
I'm going to double check that the correct callbacks are called when I'm at home where my Mac is. |
justinmc
force-pushed
the
apple-text-handle-swap
branch
2 times, most recently
from
98c6e71 to
c7b4ea6
Compare
justinmc
force-pushed
the
apple-text-handle-swap
branch
from
c7b4ea6 to
53dd9fd
Compare
Contributor
Author
|
The callbacks were correct; the left handle is always the "start" handle and the right handle is always the "end", regardless of whether they represent the base or offset. However, I was missing a case where the handles were already reversed before the drag started. I also added on to the test to cover that case. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 14, 2022
8 tasks
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
Dragging the base text selection handle on Apple makes it the extent.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS, dragging the base handle causes it to become the extent handle, so that subsequent "shift + arrow key" events move the previously dragged handle.
Discovered while working on #102992.
This video shows the correct iOS behavior after this PR.
Screen.Recording.2022-05-31.at.4.02.42.PM.mov