Update README to respect GitHub site theme by cadenkriese · Pull Request #105189 · flutter/flutter

cadenkriese · 2022-06-02T02:58:08Z

GitHub recently added support for specifying an alternate appearance when the site is using a dark theme (see the changelog). I've implemented this here with download links from https://flutter.dev/brand.

Before:

After:

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

Requesting test exemption @Hixie

GitHub recently added support for specifying an alternate appearance when the site is using a dark theme [(see the changelog)](https://github.blog/changelog/2022-05-19-specify-theme-context-for-images-in-markdown-beta/). I've implemented this here with download links from https://flutter.dev/brand.

README.md

Hixie · 2022-06-02T07:03:14Z

This is great!

guidezpl

Nice on the eyes

…05189)

* Update README to respect GitHub site theme GitHub recently added support for specifying an alternate appearance when the site is using a dark theme [(see the changelog)](https://github.blog/changelog/2022-05-19-specify-theme-context-for-images-in-markdown-beta/). I've implemented this here with download links from https://flutter.dev/brand. * Change alt text

…05189)

Hixie reviewed Jun 2, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

Change alt text

823ed92

cadenkriese requested a review from Hixie June 2, 2022 08:03

guidezpl approved these changes Jun 2, 2022

View reviewed changes

guidezpl merged commit 3c6719b into flutter:master Jun 2, 2022

engine-flutter-autoroll mentioned this pull request Jun 2, 2022

Roll Flutter from 36fe51524f72 to 048d65e0e138 (136 revisions) flutter/packages#2187

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

1404f88

…05189)

engine-flutter-autoroll mentioned this pull request Jun 2, 2022

Roll Flutter from 36fe51524f72 to 3d6fa2761a62 (137 revisions) flutter/packages#2190

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

2f67935

…05189)

engine-flutter-autoroll mentioned this pull request Jun 2, 2022

Roll Flutter from 36fe51524f72 to 8dbc3884d9ad (138 revisions) flutter/packages#2191

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

7bf36d7

…05189)

engine-flutter-autoroll mentioned this pull request Jun 2, 2022

Roll Flutter from 36fe51524f72 to dffddf00a22e (139 revisions) flutter/packages#2192

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

5936a88

…05189)

engine-flutter-autoroll mentioned this pull request Jun 2, 2022

Roll Flutter from 36fe51524f72 to 4ec4c249ea5d (140 revisions) flutter/packages#2193

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

f187f69

…05189)

cadenkriese deleted the patch-1 branch June 2, 2022 18:23

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from 36fe51524f72 to d4a963165143 (164 revisions) flutter/packages#2196

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

f38c814

…05189)

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from 36fe51524f72 to 975e04ba6d48 (165 revisions) flutter/packages#2197

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

e70d7c8

…05189)

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from 36fe51524f72 to 889a15eb9df6 (167 revisions) flutter/packages#2198

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

9b5c355

…05189)

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from e8995736bf55 to 889a15eb9df6 (176 revisions) flutter/plugins#5905

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

69f5f3c

…05189)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 2e1ebd83b3f6 (173 revisions) flutter/packages#2202

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

0a6cfa5

…05189)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 7996527b7db8 (174 revisions) flutter/packages#2203

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

63cc6a4

…05189)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 81f89aaf6c56 (175 revisions) flutter/packages#2204

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

92fcdd2

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

3a9d8b9

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

592c16e

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

f84ff67

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

3eaa523

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

f2f3437

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

77b62f5

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

29b870e

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

7eec7c6

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

d2fba1b

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

5bcb7d8

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

1dc57cf

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

e28386f

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

d209b93

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

8b84e56

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

0b7495c

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

ab3fed3

…05189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022

3c6719b Update README to respect GitHub site theme (flutter/flutter#1…

0f95fc8

…05189)

timsneath mentioned this pull request Dec 13, 2022

Regression to Logo on README.md #117003

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update README to respect GitHub site theme#105189

Update README to respect GitHub site theme#105189
guidezpl merged 2 commits intoflutter:masterfrom
cadenkriese:patch-1

cadenkriese commented Jun 2, 2022

Uh oh!

Uh oh!

Hixie commented Jun 2, 2022

Uh oh!

guidezpl left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

cadenkriese commented Jun 2, 2022

Pre-launch Checklist

Uh oh!

Uh oh!

Hixie commented Jun 2, 2022

Uh oh!

guidezpl left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants