Reland: "Add example and troubleshooting comment for showSnackBar"#105195
Conversation
flutter-dashboard
bot
added
d: api docs
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
LGTM - but do not land this, checking the affected customer tests first.
There was a problem hiding this comment.
| final bool snackBarVisible = (snackBarYOffsetBase - snackBarSize.height) > 0; | |
| final bool snackBarVisible = (snackBarYOffsetBase - snackBarSize.height) >= 0; |
Should this be >= ? Wouldn't a position at the top edge be valid?
There was a problem hiding this comment.
Good catch! I pushed a fix and updated the related test to check several SnackBar positions (fully offscreen, partially offscreen, right on the top). Thanks!.
bleroux
force-pushed
the
floating_snackbar_troubleshooting
branch
4 times, most recently
from
29ff0ea to
be616e6
Compare
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Hey @bleroux can you update this branch with the latest from master? There was a big braking change I was helping @TahaTesser get in first. I think we can move this forward now once it is updated.
I appreciate your patience. I try to migrate customers for one change at a time to keep it sane and organized. :)
bleroux
force-pushed
the
floating_snackbar_troubleshooting
branch
from
be616e6 to
a1e07f8
Compare
|
Hey @Piinks! I have rebased the PR, it seems to be ok.
I really appreciate your reviews too! You do such a great job: working on your own PRs, reviewing relentlessly other contributors' PRs, addressing customers migration and also participating in many Flutter team great videos! 💙 |
|
Thanks very much! I am running against internal tests now. |
|
Thanks for your patience! All of the customers are fixed. 🎉 |
2 participants
Description
Reland #102073, which was reverted in #104843
Related issues
Fixes #84263