Pass run and drive --trace-systrace for iOS#105321
Pass run and drive --trace-systrace for iOS#105321fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
platform-ios
|
Closing, @gaaclarke is taking this over. |
|
Now that I've debugged the issue I think this is good. All the other problems are in different repos and/or can be addressed separately. Thanks @jmagman. |
|
(Oh, I'm going to remove the "fixes" annotation too.) |
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
Please update the documentation:
--- a/packages/flutter_tools/lib/src/commands/run.dart
+++ b/packages/flutter_tools/lib/src/commands/run.dart
@@ -112,7 +112,8 @@ abstract class RunCommandBase extends FlutterCommand with DeviceBasedDevelopment
..addFlag('trace-systrace',
negatable: false,
help: 'Enable tracing to the system tracer. This is only useful on '
- 'platforms where such a tracer is available (Android and Fuchsia).',
+ 'platforms where such a tracer is available (Android, iOS, '
+ 'macOS and Fuchsia).',
)
..addFlag('trace-skia',
negatable: false,
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
I just went ahead and changed it for you (\me pats himself on the back)
Thank you :deep bow: |
|
Yea, I think that may only work on files that already have edits on them though. Maybe if you jump into the full github editor you can start commenting on files that haven't changed? |
oh right right right |
| help: 'Enable tracing to the system tracer. This is only useful on ' | ||
| 'platforms where such a tracer is available (Android and Fuchsia).', | ||
| 'platforms where such a tracer is available (Android, iOS, ' | ||
| 'macOS and Fuchsia).', |
There was a problem hiding this comment.
Is it set up in the engine for macOS?
There was a problem hiding this comment.
Dart supports it, I didn't verify that the engine is piping it down to dart correctly though. I'm not too familiar with the macos flow.
There was a problem hiding this comment.
So should this have been changed to document that it works on macOS?
There was a problem hiding this comment.
Yea, macOS is a platform "where such a tracer is available".
3 participants
issue #105253
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.