Skip to content

TextFormField docs: added proper type with GlobalKey; replaced "we"#105605

Merged
HansMuller merged 2 commits intoflutter:masterfrom
EnduringBeta:text-form-field-doc-tweaks
Jun 16, 2022
Merged

TextFormField docs: added proper type with GlobalKey; replaced "we"#105605
HansMuller merged 2 commits intoflutter:masterfrom
EnduringBeta:text-form-field-doc-tweaks

Conversation

@EnduringBeta
Copy link
Contributor

@EnduringBeta EnduringBeta commented Jun 8, 2022

2 small doc changes for TextFormField. See issue for more context.

#105603

Also, I'd like to point out that the link to the Contributor Guide below goes to the Tree Hygiene overview. Should it be this? https://github.com/flutter/flutter/blob/master/CONTRIBUTING.md

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 8, 2022
@EnduringBeta
Copy link
Contributor Author

EnduringBeta commented Jun 8, 2022 •
edited
Loading

I'm not sure how to test that the doc link still works fine. Maybe it needs to be one of these:

  • [GlobalKey]<FormFieldState>
  • [GlobalKey]<[FormFieldState]>

I'd also understand if I'm mistaken on this entirely.

@EnduringBeta EnduringBeta changed the title added proper type with GlobalKey; replaced "we" TextFormField docs: added proper type with GlobalKey; replaced "we" Jun 8, 2022
@HansMuller HansMuller requested a review from justinmc June 9, 2022 16:29
HansMuller
HansMuller approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

gspencergoog
gspencergoog reviewed Jun 13, 2022
View reviewed changes
@EnduringBeta @gspencergoog
Update packages/flutter/lib/src/material/text_form_field.dart
092e08f 
fixed broken link syntax in docs with separate parenthetical

Co-authored-by: Greg Spencer <[email protected]>
gspencergoog
gspencergoog approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@HansMuller HansMuller merged commit 695cfa4 into flutter:master Jun 16, 2022
@EnduringBeta EnduringBeta deleted the text-form-field-doc-tweaks branch June 16, 2022 16:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
695cfa4 TextFormField docs: added proper type with GlobalKey; replace…
531e3b5 
…d "we" (flutter/flutter#105605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
695cfa4 TextFormField docs: added proper type with GlobalKey; replace…
54d2425 
…d "we" (flutter/flutter#105605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
695cfa4 TextFormField docs: added proper type with GlobalKey; replace…
6bab74e 
…d "we" (flutter/flutter#105605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
695cfa4 TextFormField docs: added proper type with GlobalKey; replace…
84d1bfb 
…d "we" (flutter/flutter#105605)
@HansMuller HansMuller mentioned this pull request Jun 23, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@EnduringBeta @camsim99
TextFormField docs: added proper type with GlobalKey; replaced "we" (f…
da8f549 
…lutter#105605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
695cfa4 TextFormField docs: added proper type with GlobalKey; replace…
1a75029 
…d "we" (flutter/flutter#105605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
695cfa4 TextFormField docs: added proper type with GlobalKey; replace…
2d2c0c1 
…d "we" (flutter/flutter#105605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@justinmc justinmc Awaiting requested review from justinmc

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EnduringBeta @HansMuller @gspencergoog