Add error messages to _debugCanPerformMutations#105638
Add error messages to _debugCanPerformMutations#105638auto-submit[bot] merged 8 commits intoflutter:masterfrom
_debugCanPerformMutations#105638Conversation
flutter-dashboard
bot
added
the
framework
LongCatIsLooong
force-pushed
the
_debugCanPerformMutations
branch
from
ba513f2 to
9c17dab
Compare
There was a problem hiding this comment.
Previously, this condition was checked on every node on the path to the activeLayoutRoute, but now it is only checked for the activeLayoutRoot. For my own understanding, why is this change considered ok?
There was a problem hiding this comment.
The original implementation seems to make more sense. Changed.
There was a problem hiding this comment.
Other methods then markNeedsLayout check _debugCanPerformMutations - wouldn't this message be confusing in those cases?
There was a problem hiding this comment.
changed was marked as needing layout to was mutated.
There was a problem hiding this comment.
We should test that the right ROs are mentioned in these errors.
There was a problem hiding this comment.
Do you actually need the result variable anymore? Seems like this either returns true now or it throws so we could simplify the code and remove this?
There was a problem hiding this comment.
Only when the result is true I think (so the assert doesn't assert). One thing this provides is since result is a late final, if _debugCanPerformMutations is accidentally called in release mode it crashes.
LongCatIsLooong
force-pushed
the
_debugCanPerformMutations
branch
from
efaf1b9 to
ff8a28d
Compare
LongCatIsLooong
added
the
autosubmit
2 participants
Separated from #105335. TGP passed: OCL:453732336:BASE:453732204:1654815855431:ecc85b03
Fixes #87423 I guess
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.