Added useMaterial3 parameters to the light, dark and fallback ThemeData constructors.#105944
Merged
darrenaustin merged 1 commit intoflutter:masterfrom Jun 14, 2022
darrenaustin:m3_theme_constructors
Merged
Added useMaterial3 parameters to the light, dark and fallback ThemeData constructors.#105944darrenaustin merged 1 commit intoflutter:masterfrom darrenaustin:m3_theme_constructors
darrenaustin merged 1 commit intoflutter:masterfrom
darrenaustin:m3_theme_constructors
Conversation
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 15, 2022
… ThemeData constructors. (flutter/flutter#105944)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 15, 2022
… ThemeData constructors. (flutter/flutter#105944)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 15, 2022
… ThemeData constructors. (flutter/flutter#105944)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 15, 2022
… ThemeData constructors. (flutter/flutter#105944)
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
… ThemeData constructors. (flutter/flutter#105944)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
… ThemeData constructors. (flutter/flutter#105944)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting
useMaterial3to true withThemeData.copyWith, it has no way of updating the defaults fortypographyandsplashFactoryas they were already set in the constructor. For applications that are using thelight,dark, orfallbackconstructors for ThemeData, this PR providesuseMaterial3parameters to each of them that allow them to have the appropriate Material 3 defaults for the typography and splash factories:This will hopefully help with #105578.
Pre-launch Checklist
///).