[Conductor] Clean up post release instructions.#106026
[Conductor] Clean up post release instructions.#106026itsjustkevin merged 1 commit intoflutter:masterfrom itsjustkevin:conductor_post-release_comms
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
itsjustkevin
requested review from
XilaiZhang and
muditatandon
and removed request for
christopherfujino
XilaiZhang
left a comment
XilaiZhang
left a comment
There was a problem hiding this comment.
Overall LGTM. Thanks for cleaning up!
| import 'package:platform/platform.dart'; | ||
|
|
||
| import './globals.dart'; | ||
| import './globals.dart' as globals; |
There was a problem hiding this comment.
nit: umm yeah I think this would cause variables and functions to be prefixed with globals.variables. just more typings in my opinion.
There was a problem hiding this comment.
That is a fair assessment. My reasoning behind prefixing is to make it easier to find out where the variables are coming from. It is also consistent with some of the other prefixes.
There was a problem hiding this comment.
umm looking at repository/start/next/state/clean.dart they seem to be not prefixed. Is our plan going forward to prefix them as well? I can RSLGTM
There was a problem hiding this comment.
yeah personally i d prefer without the prefix but its really nit
2 participants
This PR contains the following: