Skip to content

[gen_keycodes] Mark generated file names with infix .g.#106142

Merged
auto-submit[bot] merged 5 commits intoflutter:masterfrom
dkwingsmt:mark-generated-files
Jun 30, 2022
Merged

[gen_keycodes] Mark generated file names with infix .g.#106142
auto-submit[bot] merged 5 commits intoflutter:masterfrom
dkwingsmt:mark-generated-files

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jun 16, 2022 •
edited
Loading

This PR changes the names of the auto-generated files to contain infix .g., hopefully making it more obvious that they should not be directly modified.

The Android files are excluded because of Java's naming convention.

The engine changes are applied in flutter/engine#34123.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 16, 2022
@dkwingsmt dkwingsmt mentioned this pull request Jun 16, 2022
Merged
8 tasks
@flutter-dashboard flutter-dashboard bot added the f: material design flutter/packages/flutter/material repository. label Jun 16, 2022
@dkwingsmt dkwingsmt requested a review from gspencergoog June 21, 2022 20:27
@dkwingsmt dkwingsmt changed the title [gen_keycodes] Mark generated files with .g. [gen_keycodes] Mark generated file names with infix .g. Jun 21, 2022
@dkwingsmt dkwingsmt force-pushed the mark-generated-files branch from 4daf225 to eac7ea4 Compare June 23, 2022 23:17
gspencergoog
gspencergoog approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2022
@auto-submit auto-submit bot merged commit 9970481 into flutter:master Jun 30, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 30, 2022
@engine-flutter-autoroll
9970481 [gen_keycodes] Mark generated file names with infix .g. (fl…
f868ea4 
…utter/flutter#106142)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2022
@engine-flutter-autoroll
9970481 [gen_keycodes] Mark generated file names with infix .g. (fl…
8916c1a 
…utter/flutter#106142)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2022
@engine-flutter-autoroll
9970481 [gen_keycodes] Mark generated file names with infix .g. (fl…
352bcc6 
…utter/flutter#106142)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@dkwingsmt @camsim99
[gen_keycodes] Mark generated file names with infix .g. (flutter#10…
94aed23 
…6142)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
9970481 [gen_keycodes] Mark generated file names with infix .g. (fl…
4871a71 
…utter/flutter#106142)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
9970481 [gen_keycodes] Mark generated file names with infix .g. (fl…
3e91eaf 
…utter/flutter#106142)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkwingsmt @gspencergoog