[flutter_tools] migrate project-validate to analyze --suggestions#106149
Merged
auto-submit[bot] merged 11 commits intoflutter:masterfrom Jun 24, 2022
Merged
[flutter_tools] migrate project-validate to analyze --suggestions#106149auto-submit[bot] merged 11 commits intoflutter:masterfrom
auto-submit[bot] merged 11 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
Jasguerrero
changed the title
Jasguerrero
commented
Jun 17, 2022
Contributor
There was a problem hiding this comment.
From reading the code, it sounds like it's not the "current" project, but whatever project is at the path pointed to by this option, right?
Contributor
There was a problem hiding this comment.
Can I suggest you make this usage consistent with the rest of flutter analyze (from a brief look at the code, there's a --current-package flag, that defaults to on, and then the argResults.rest is parsed as directories or files and canonicalized)
Contributor
There was a problem hiding this comment.
style nit: put this else on the previous line
Contributor
There was a problem hiding this comment.
I think this can be declared where it is set, on line 141. If someone later adds code that tries to reference this outside the scope where it's initialized, it will be a runtime error that the compiler can't catch.
Jasguerrero
force-pushed
the
move_validate_to_flag
branch
from
d882f6b to
8a62570
Compare
Jasguerrero
added
the
autosubmit
This was referenced Jun 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 28, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2885
As suggested by the team this should be a flag inside
flutter analyzeinstead of a new commandPre-launch Checklist
///).