Refactoring the setPubRootDirectory tests#106197
Merged
CoderDake merged 14 commits intoflutter:masterfrom Jun 22, 2022
Merged
Conversation
flutter-dashboard
bot
added
the
framework
CoderDake
changed the title
CoderDake
changed the title
HansMuller
added
f: inspector
jacob314
reviewed
Jun 17, 2022
jacob314
reviewed
Jun 17, 2022
jacob314
reviewed
Jun 17, 2022
jacob314
reviewed
Jun 17, 2022
jacob314
reviewed
Jun 17, 2022
Contributor
jacob314
left a comment
jacob314
left a comment
There was a problem hiding this comment.
Looks like good test cleanup refactoring overall. A few small comments on how to make it cleaner.
jacob314
reviewed
Jun 17, 2022
CoderDake
force-pushed
the
pubRootTestPrep
branch
from
61b0aa4 to
859ec4a
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 23, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small refactor to the specs that test
setPubRootDirectoriesin the widget_inspector. These changes to the setPubRootTests will make the upcoming PR for #105730 a bit clearer, since the pubRoot tests will be modified to accommodate the new interactions.In preparation for #105730
Pre-launch Checklist
///).