Pass app.started events to the DAP client + dart.debuggerUris for Profile mode#106337
Pass app.started events to the DAP client + dart.debuggerUris for Profile mode#106337fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
This allows a DAP client to know when an app has finished launching even if there is no VM Service (such as noDebug runs). Fixes Dart-Code/Dart-Code#3945 (with some client updates).
flutter-dashboard
bot
added
the
tool
DanTup
changed the title
| 'vmServiceUri': serviceUri.toString(), | ||
| }), | ||
| eventType: 'dart.debuggerUris', | ||
| ); |
There was a problem hiding this comment.
I have a CL that adds a method to the base to avoid duplicating it here, but it needs a new DDS release (and then rolling into here). Assuming that doesn't happen before this is ready, I'll sort this in a separate PR once it does.
There was a problem hiding this comment.
are you saying the DDS change hasn't been published yet?
There was a problem hiding this comment.
It's in DDS 2.2.3 published today, however that can't be rolled into Flutter yet due to a conflicting vm_service constraint with DWDS.
In case it isn't clear, the DDS change is not required for this code to function, only to replace lines 412-417 with a simpler base method call so that the Flutter adapter doesn't need to construct the dart.debuggerUris message itself.
There was a problem hiding this comment.
I'm guessing it's (going to be) this
Yup! The real change was this, which is just extracting a method so this Flutter adapter can call it:
There was a problem hiding this comment.
It's in DDS 2.2.3 published today, however that can't be rolled into Flutter yet due to a conflicting vm_service constraint with DWDS.
In case it isn't clear, the DDS change is not required for this code to function, only to replace lines 412-417 with a simpler base method call so that the Flutter adapter doesn't need to construct the
dart.debuggerUrismessage itself.
Understood, I was hoping I could roll forward to simplify this change, but I understand we're blocked on transitive deps.
3 participants
This allows a DAP client to know when an app has finished launching even if there is no VM Service (such as noDebug runs) and also still get the VM Service URI in the case where the adapter doesn't connect to it itself (Profile mode - where we use VM Service for DevTools in the client, but don't provide any debugging).
Fixes Dart-Code/Dart-Code#3945 (with some client updates).
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.