[flutter_driver] support send text input action by nploi · Pull Request #106561 · flutter/flutter

nploi · 2022-06-24T14:35:10Z

Currently, we don't support keyboard events in flutter_driver, this PR will be support that feature.

List which issues are fixed by this PR. You must list at least one issue.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

goderbauer · 2022-06-29T21:31:45Z

@nploi Looks like this PR is failing some checks. Can you take a look and fix those up? Thanks!

nploi · 2022-06-30T15:42:11Z

@nploi Looks like this PR is failing some checks. Can you take a look and fix those up? Thanks!

yes, sure!, i writing more unit-test for this.

nploi · 2022-07-04T02:28:16Z

Hi @dkwingsmt, please help me review this PR. thanks.

goderbauer · 2022-07-06T21:41:10Z

@nploi It looks like some of the checks are still failing on this PR. Can you please take a look and fix those issues? Thanks!

dkwingsmt

Also, add the following comment to services/TextInputAction:

// This class has been cloned to `flutter_driver/lib/src/common/action.dart` as `TextInputAction`,
// and must be kept in sync.

dkwingsmt · 2022-07-07T15:22:28Z

packages/flutter_driver/lib/src/common/handler_factory.dart

Is this section simply reformatting? Unless there is solid reasons, I don't think you should reformat existing code.

The same for other places in this file.

yes, my editor auto reformat, i reverted.

packages/flutter_driver/lib/src/driver/driver.dart

packages/flutter_driver/lib/src/common/action.dart

dkwingsmt · 2022-07-07T15:36:09Z

packages/flutter_driver/lib/src/common/action.dart

Is it needed to rename it or can we keep TextInputAction?

yes, we needed to rename, because it conflict with TextInputAction class.

let me try to rename.

packages/flutter_driver/lib/src/common/action.dart

dkwingsmt · 2022-07-07T15:38:11Z

packages/flutter_driver/lib/src/driver/driver.dart

Same as the ReceiveAction class: can we rename it to sendTextInputAction?

done, thanks.

dkwingsmt · 2022-07-07T15:38:27Z

packages/flutter_driver/test/src/real_tests/flutter_driver_test.dart

done, thanks.

dkwingsmt · 2022-07-07T15:39:15Z

packages/flutter_driver/lib/src/common/action.dart

If the class is renamed, keep this string in sync.

done, thanks.

dkwingsmt · 2022-07-07T15:42:04Z

packages/flutter_driver/lib/src/common/action.dart

Can we rename the file to text_input_action.dart?

done, thanks.

flutter-dashboard · 2022-07-07T16:02:10Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

nploi · 2022-07-07T17:39:32Z

Hi @dkwingsmt, i fixed your comments, pls help me re-review. thanks.

dkwingsmt

Minor change requests about the comments. Otherwise good to go.

dkwingsmt · 2022-07-11T19:45:14Z

packages/flutter/lib/src/services/text_input.dart

This new paragraph should intentionally be a normal comment (starting with //, after the dart doc) instead of a dart doc (starting with ///). A dart doc is visible to the end developers, but the developers should not care about what's in flutter_driver. This paragraph is only meant for Flutter framework developers who might edit this class.

Fixed, thank you so much.

dkwingsmt · 2022-07-11T20:19:40Z

packages/flutter_driver/lib/src/common/text_input_action.dart

Suggested change

///

/// This class is identical to [TextInputAction](https://api.flutter.dev/flutter/services/TextInputAction.html).

/// This class is cloned from `TextInputAction` and must be kept in sync. The cloning is needed

/// because importing is not allowed directly.

// This class is identical to [TextInputAction](https://api.flutter.dev/flutter/services/TextInputAction.html).

// This class is cloned from `TextInputAction` and must be kept in sync. The cloning is needed

// because importing is not allowed directly.

Fixed, thanks.

AUTHORS

jonahwilliams · 2022-07-11T20:30:19Z

packages/flutter_driver/lib/src/driver/driver.dart

We should probably update these code blocks so that they are analyzed. You can do it for just this one by adding:

/// {@tool snippet} /// ... The existing sample code /// {@end-tool}

yes, i updated, thanks.

jonahwilliams · 2022-07-11T20:31:51Z

packages/flutter_driver/lib/src/common/text_input_action.dart

Do we do this for other enums in this package? if so, I'd be worried about keeping them in sync. It would be great to have a test that checked that they had the same entries at least

hi @jonahwilliams
i tried to use the same entries, but build error because that package include UI, so it can't compile in server side.

Do you have any suggestion for me ? Thanks.

I don't mean using the same enum, I mean writing a test that verifies that these enums have the same values. i.e. in the test open the files and check the values

ah, i got it, let me write a test for it. thanks.

@jonahwilliams , i added unit-test for do it, pls help me review again.

jonahwilliams · 2022-07-13T18:18:00Z

packages/flutter_driver/test/src/real_tests/text_input_action_test.dart

jonahwilliams

LGTM

dkwingsmt

LGTM once tests are fixed. Well done and thank you!

dkwingsmt · 2022-07-14T16:22:28Z

I'm not sure why these customer tests are failing. Can you try to rebase your PR onto the latest master?

Co-authored-by: Tong Mu <[email protected]>

…ter#106561)

* Support receive input action * Fix error syntax * Fix compile * Add documents * Add unit-test * Update import * Fixed unit-test and lint * Add authors for me * Fixed lint * Fixed lint * Add example * Fixed lint * Fix gen docs * Revert code * Remove flutter_dev * Update packages/flutter_driver/lib/src/driver/driver.dart Co-authored-by: Tong Mu <[email protected]> * Update packages/flutter_driver/lib/src/common/action.dart Co-authored-by: Tong Mu <[email protected]> * Update packages/flutter_driver/lib/src/common/action.dart Co-authored-by: Tong Mu <[email protected]> * Rename ReceiveAction to SendTextInputAction * Rename DriverTextInputAction to TextInputAction and fix unit-test * Reorder import * Remove space * Reorder import * Update text_input.dart * Update flutter_driver_test.dart * Update comment to normal comment after dart doc * Update example * Update AUTHORS Co-authored-by: Tong Mu <[email protected]> * Fix analyze * Add type dart for example * Add unit-test to check the same entries Co-authored-by: Tong Mu <[email protected]>

…endTextInputAction usages through flutter_driver. (#139197) **As a follow up to #131776 **Summary:** Previously in #106561, SendTextInputAction was added to Flutter Driver. But it still cannot be used from flutter_driver tests. This PR intends to resolve that issue. **Issue:** An `DriverError: Unsupported command kind send_text_input_action` would be thrown from `flutter_driver/lib/src/common/deserialization_factory.dart` when a call to `driver.sendTextInputAction(TextInputAction.done);` was made despite the method `sendTextInputAction` is available for use since #106561. Previous works has been done in #131776, I merely added tests. Best regards.

…endTextInputAction usages through flutter_driver. (flutter#139197) **As a follow up to flutter#131776 **Summary:** Previously in flutter#106561, SendTextInputAction was added to Flutter Driver. But it still cannot be used from flutter_driver tests. This PR intends to resolve that issue. **Issue:** An `DriverError: Unsupported command kind send_text_input_action` would be thrown from `flutter_driver/lib/src/common/deserialization_factory.dart` when a call to `driver.sendTextInputAction(TextInputAction.done);` was made despite the method `sendTextInputAction` is available for use since flutter#106561. Previous works has been done in flutter#131776, I merely added tests. Best regards.

flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jun 24, 2022

nploi marked this pull request as ready for review June 30, 2022 17:04

HansMuller requested a review from dkwingsmt July 1, 2022 21:45

dkwingsmt requested changes Jul 7, 2022

View reviewed changes

dkwingsmt reviewed Jul 7, 2022

View reviewed changes

nploi marked this pull request as draft July 7, 2022 15:57

nploi changed the title ~~[flutter_driver] support receive input action~~ [flutter_driver] support send text input action Jul 7, 2022

flutter-dashboard bot added the a: text input Entering text in a text field or keyboard related problems label Jul 7, 2022

nploi marked this pull request as ready for review July 7, 2022 17:37

nploi requested a review from dkwingsmt July 7, 2022 17:37

dkwingsmt requested changes Jul 11, 2022

View reviewed changes

jonahwilliams reviewed Jul 11, 2022

View reviewed changes

nploi marked this pull request as draft July 12, 2022 02:23

nploi marked this pull request as ready for review July 12, 2022 02:40

nploi requested review from dkwingsmt and jonahwilliams July 12, 2022 02:40

jonahwilliams reviewed Jul 13, 2022

View reviewed changes

packages/flutter_driver/test/src/real_tests/text_input_action_test.dart Outdated

Copy link

Contributor

jonahwilliams Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! 👍

jonahwilliams approved these changes Jul 13, 2022

View reviewed changes

dkwingsmt approved these changes Jul 14, 2022

View reviewed changes

nploi added 2 commits July 15, 2022 01:43

Support receive input action

b74403a

Fix error syntax

15ee94f

nploi and others added 15 commits July 15, 2022 01:46

Update packages/flutter_driver/lib/src/common/action.dart

9060dcc

Co-authored-by: Tong Mu <[email protected]>

Update packages/flutter_driver/lib/src/common/action.dart

23d01a1

Co-authored-by: Tong Mu <[email protected]>

Rename ReceiveAction to SendTextInputAction

a8260bb

Rename DriverTextInputAction to TextInputAction and fix unit-test

d2b7d4d

Reorder import

cafb86d

Remove space

5d48e8a

Reorder import

1742c5b

Update text_input.dart

158f769

Update flutter_driver_test.dart

a109207

Update comment to normal comment after dart doc

8c39e5e

Update example

07e5cab

Update AUTHORS

7c96612

Co-authored-by: Tong Mu <[email protected]>

Fix analyze

e17dfb2

Add type dart for example

6c82e03

Add unit-test to check the same entries

0a3296b

dkwingsmt merged commit 0cf9d41 into flutter:master Jul 15, 2022

This was referenced Jul 15, 2022

Roll Flutter from 5a5d021e51ca to bbec650b64bc (22 revisions) flutter/plugins#6107

Merged

Roll Flutter from 5a5d021e51ca to bbec650b64bc (22 revisions) flutter/packages#2326

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 15, 2022

0cf9d41 [flutter_driver] support send text input action (flutter/flut…

e378f52

…ter#106561)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2022

0cf9d41 [flutter_driver] support send text input action (flutter/flut…

064d662

…ter#106561)

dkwingsmt mentioned this pull request Jul 15, 2022

[Flutter Driver] How to submit a TextField? #29450

Open

nploi deleted the flutter-driver-support-receive-input-action branch July 16, 2022 05:50

nonvachara-paloit mentioned this pull request Nov 29, 2023

Add send_text_input_action case to deserialization_factory to allow sendTextInputAction usages through flutter_driver. #139197

Merged

-///
-/// This class is identical to [TextInputAction](https://api.flutter.dev/flutter/services/TextInputAction.html).
-/// This class is cloned from `TextInputAction` and must be kept in sync. The cloning is needed
-/// because importing is not allowed directly.
+// This class is identical to [TextInputAction](https://api.flutter.dev/flutter/services/TextInputAction.html).
+// This class is cloned from `TextInputAction` and must be kept in sync. The cloning is needed
+// because importing is not allowed directly.

Conversation

nploi commented Jun 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

goderbauer commented Jun 29, 2022

Uh oh!

nploi commented Jun 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nploi commented Jul 4, 2022

Uh oh!

goderbauer commented Jul 6, 2022

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Jul 7, 2022

Uh oh!

nploi commented Jul 7, 2022

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nploi Jul 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

nploi commented Jun 24, 2022 •

edited

Loading

nploi commented Jun 30, 2022 •

edited

Loading

nploi Jul 13, 2022 •

edited

Loading

dkwingsmt left a comment •

edited

Loading