[Windows] Remove the usage of SETLOCAL ENABLEDELAYEDEXPANSION from bat scripts.#106861
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I added a test. |
goderbauer
added
the
tool
|
@loic-sharma would you by any chance know how batch files work, and be able to review this change? |
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
RSLGTM, thanks for this change!
christopherfujino
added
the
autosubmit
…N` from bat scripts. (flutter/flutter#106861)
…N` from bat scripts. (flutter/flutter#106861)
4 participants
On Windows, calling another script without
CALLfrom bat script won't back to caller when callee exited. The callee can use last exit code. When the callee exits with exit code, the caller's caller can receive the code.This PR replaces the usage of
SETLOCAL ENABLEDELAYEDEXPANSIONwith this behavior.This PR also replaces the usage of it which can be replaced by normal %~%.
Fixes #26571.
No changes in the flutter/tests repo.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.