Don't disable pointer interaction during trackpad scroll by moffatman · Pull Request #106890 · flutter/flutter

moffatman · 2022-06-30T17:54:38Z

Usually pointer interaction is disabled during a drag scroll. Now that trackpad uses a continuous/drag scroll, this should be changed so that mouse hover effects and clicking is possible as it was before recent changes.

Fixes #105308

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

dkwingsmt · 2022-07-14T20:18:21Z

packages/flutter/test/widgets/scroll_activity_test.dart

    expect(find.text('Page 9'), findsOneWidget);
  });
+
+  testWidgets('Scroll device type controls whether pointer is ignored.', (WidgetTester tester) async {


Suggested change

testWidgets('Scroll device type controls whether pointer is ignored.', (WidgetTester tester) async {

testWidgets('Pointer is not ignored during trackpad scrolling.', (WidgetTester tester) async {

packages/flutter/test/widgets/scroll_activity_test.dart

dkwingsmt · 2022-07-25T22:17:06Z

A test is failing because PointerDownEvent is created with kind trackpad. Is it supposed to?

moffatman · 2022-07-26T01:45:37Z

A test is failing because PointerDownEvent is created with kind trackpad. Is it supposed to?

Was being lazy with testing the trackpad processing. I added some proper event synthesis functions and used those instead.

goderbauer · 2022-08-02T22:18:48Z

Fly-by comment from triage: looks like the analyzer is unhappy.

dkwingsmt

LGTM

dkwingsmt · 2022-08-16T22:48:54Z

cc @Piinks

Piinks · 2022-08-16T23:31:46Z

packages/flutter/lib/src/widgets/scroll_activity.dart

    super.delegate,
    Simulation simulation,
    TickerProvider vsync,
+    this.shouldIgnorePointer,


This might be a breaking change, let me run some internal tests first. One way to work around this is to make it an optional parameter with a default behavior.

Actually I was able to do a quick look up and found no uses of this class internally. ✅

I did find a breakage in an external package while testing this with my existing code, but they were only overriding BallisticScrollActivity to perform the exact same function as here.

Piinks

What happens if the user tries to drag again before the activity finishes? Will it crash? I see the test checks for tapping, but what if the user tries to drag scroll? I think the scroll view might throw because it can only have one active drag at a time..

moffatman · 2022-08-17T02:47:57Z

What happens if the user tries to drag again before the activity finishes?
I'm not sure what you mean about having two active drags at once. Once the ballistic activity starts, the previous drag has finished. And a second drag/finger during the dragging phase will be handled by the same recognizer, there won't be two drags.

Piinks · 2022-08-17T22:56:09Z

Just double checking common crashes when we make changes like these. 😉
I've checked this out and tried it, it doesn't get caught in that logic.

flutter/packages/flutter/lib/src/widgets/scrollable.dart

Line 650 in 9a4a9f7

// TOUCH HANDLERS

Piinks

LGTM

…tter/flutter#106890)

flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Jun 30, 2022

HansMuller requested a review from dkwingsmt July 1, 2022 21:43

moffatman force-pushed the trackpad_scrollable_interactive branch from f4b062d to 64ee8bd Compare July 8, 2022 04:12

dkwingsmt requested changes Jul 14, 2022

View reviewed changes

moffatman force-pushed the trackpad_scrollable_interactive branch 2 times, most recently from 77de568 to 486756b Compare July 15, 2022 16:16

goderbauer requested a review from dkwingsmt July 20, 2022 16:48

moffatman force-pushed the trackpad_scrollable_interactive branch from 486756b to f7ff2fa Compare July 25, 2022 15:14

moffatman added 4 commits August 4, 2022 23:52

Don't disable pointer interaction during trackpad scroll

cfbe488

Handle ballistic phase, improve test

5abd6cc

Improve/fix test

5b26282

Fix analyzer failure

1c8623e

moffatman force-pushed the trackpad_scrollable_interactive branch from 2c128a0 to 1c8623e Compare August 5, 2022 03:52

dkwingsmt approved these changes Aug 16, 2022

View reviewed changes

Piinks reviewed Aug 16, 2022

View reviewed changes

Piinks approved these changes Aug 17, 2022

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2022

auto-submit bot merged commit 09e400e into flutter:master Aug 17, 2022

This was referenced Aug 18, 2022

Roll Flutter from cb936c51f8b2 to 9eca99b8df79 (31 revisions) flutter/packages#2470

Merged

Roll Flutter from cb936c51f8b2 to 9eca99b8df79 (31 revisions) flutter/plugins#6291

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2022

09e400e Don't disable pointer interaction during trackpad scroll (flu…

c19d9f8

…tter/flutter#106890)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 18, 2022

09e400e Don't disable pointer interaction during trackpad scroll (flu…

7cd515e

…tter/flutter#106890)

moffatman mentioned this pull request Oct 7, 2022

[macOS] - Cursor doesn't interact as expected while scrolling #112760

Closed

JohannSchramm mentioned this pull request Jan 27, 2023

Ballistic Animation was updated in Flutter 3.7.0 and breaks both packages jamesblasco/modal_bottom_sheet#317

Closed

Michal-MK mentioned this pull request Mar 22, 2024

BouncingScrollPhysics Capturing all input until settled #145330

Closed

	testWidgets('Scroll device type controls whether pointer is ignored.', (WidgetTester tester) async {
	testWidgets('Pointer is not ignored during trackpad scrolling.', (WidgetTester tester) async {

Conversation

moffatman commented Jun 30, 2022

Pre-launch Checklist

Uh oh!

dkwingsmt Jul 14, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dkwingsmt commented Jul 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moffatman commented Jul 26, 2022

Uh oh!

goderbauer commented Aug 2, 2022

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt commented Aug 16, 2022

Uh oh!

Piinks Aug 16, 2022

Choose a reason for hiding this comment

Uh oh!

Piinks Aug 16, 2022

Choose a reason for hiding this comment

Uh oh!

moffatman Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

moffatman commented Aug 17, 2022

Uh oh!

Piinks commented Aug 17, 2022

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dkwingsmt commented Jul 25, 2022 •

edited

Loading