Skip to content

Reland "Disable cursor opacity animation on macOS, make iOS cursor animation discrete (#104335)"#106893

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
LongCatIsLooong:reland-104335
Jul 8, 2022
Merged

Reland "Disable cursor opacity animation on macOS, make iOS cursor animation discrete (#104335)"#106893
auto-submit[bot] merged 2 commits intoflutter:masterfrom
LongCatIsLooong:reland-104335

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Jun 30, 2022 •
edited
Loading

TGP => OCL:459558623:BASE:459559716:1657240390400:7a09b29b

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 30, 2022
LongCatIsLooong
LongCatIsLooong commented Jun 30, 2022
View reviewed changes
packages/flutter/test/material/text_field_test.dart
// Selection should stay the same since it is set on tap up for mobile platforms.
await touchGesture.down(gPos);
await tester.pumpAndSettle();
await tester.pump();
Copy link
Contributor Author

@LongCatIsLooong LongCatIsLooong Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to change 2 tests since the test gesture was meant to be a tap but ended up being a long press.

Copy link
Contributor Author

@LongCatIsLooong LongCatIsLooong Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Renzo-Olivares are you ok with this change?

@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review June 30, 2022 20:17
@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Jul 7, 2022

No relevant failures on test TGP run. Ready for review.

Renzo-Olivares
Renzo-Olivares approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I'm okay with the test changes.

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 8, 2022
@auto-submit auto-submit bot merged commit c58dca2 into flutter:master Jul 8, 2022
@LongCatIsLooong LongCatIsLooong deleted the reland-104335 branch July 8, 2022 20:30
This was referenced Jul 9, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2022
@engine-flutter-autoroll
c58dca2 Reland "Disable cursor opacity animation on macOS, make iOS c…
4f45cc9 
…ursor animation discrete (#104335)" (flutter/flutter#106893)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 9, 2022
@engine-flutter-autoroll
c58dca2 Reland "Disable cursor opacity animation on macOS, make iOS c…
3c7682e 
…ursor animation discrete (#104335)" (flutter/flutter#106893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 9, 2022
@engine-flutter-autoroll
c58dca2 Reland "Disable cursor opacity animation on macOS, make iOS c…
9c3f6f4 
…ursor animation discrete (#104335)" (flutter/flutter#106893)
@LongCatIsLooong LongCatIsLooong mentioned this pull request Jul 26, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@LongCatIsLooong @camsim99
Reland "Disable cursor opacity animation on macOS, make iOS cursor an…
c1bd4c5 
…imation discrete (flutter#104335)" (flutter#106893)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
c58dca2 Reland "Disable cursor opacity animation on macOS, make iOS c…
bbaa768 
…ursor animation discrete (#104335)" (flutter/flutter#106893)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
c58dca2 Reland "Disable cursor opacity animation on macOS, make iOS c…
d9f023d 
…ursor animation discrete (#104335)" (flutter/flutter#106893)
@darshankawar darshankawar mentioned this pull request Oct 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@justinmc justinmc Awaiting requested review from justinmc

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LongCatIsLooong @Renzo-Olivares