Fix some issues with launching E2E benchmarks and add page delays in textfield benchmarks#107500
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Jul 14, 2022
Merged
Conversation
…textfield benchmarks
jason-simmons
approved these changes
Jul 13, 2022
This was referenced Jul 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 14, 2022
…lays in textfield benchmarks (flutter/flutter#107500)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 14, 2022
…lays in textfield benchmarks (flutter/flutter#107500)
Member
|
SkiaPerf is recording a plethora of improvements and regressions on this change. Since it looks like we are changing how/what these benchmarks are measuring, my presumption is that this is expected, and doesn't actually reflect any actionable issue, but pasting the links here for confirmation: |
Contributor
Author
|
For the improvements:
For the regressions:
|
Member
|
Thanks for the detailed investigation! |
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
…textfield benchmarks (flutter#107500)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The E2E textfield benchmarks were not displaying a caret due to failing to pass along the benchmark driver properties. This problem will also affect all E2E benchmarks that use code to drive the benchmark (i.e. the textfield benchmarks had to click on the text field in order to get the caret to appear).
Also, adding a page delay to both the timeline and E2E version of these benchmarks to ensure that the page transition to the benchmark page finishes before the benchmarks start measuring.